From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932693AbdCIPmZ (ORCPT ); Thu, 9 Mar 2017 10:42:25 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:39866 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932212AbdCIPmV (ORCPT ); Thu, 9 Mar 2017 10:42:21 -0500 X-AuditID: b6c32a2c-f79b56d0000012f0-f5-58c177ac3a12 From: Bartlomiej Zolnierkiewicz To: Russell King - ARM Linux Cc: Sergei Shtylyov , Sekhar Nori , Arnd Bergmann , Dmitry Eremin-Solenikov , Kevin Hilman , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Olof Johansson , linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH] arm: assabet_defconfig: disable IDE subsystem Date: Thu, 09 Mar 2017 16:41:29 +0100 Message-id: <38186948.tezz7FzVrI@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170309150829.GM21222@n2100.armlinux.org.uk> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTYRjG+87Z5Ww4OU3TF0WlwaLMK1gc1Eqh4mgUXUBMghx6UHFza1NT KxIhNwTJC2aIhlmzNEudomZ4mzXLVNSZ2WoiKoFFSGrileU8E/zv977v83zf97x8BC42cD2I lLR0Rp0mk0t4Qk5b/7Gj/g23+2KDXi05U9slJj5VMr+IU+vaVowyzE1yKVPHLEaZOyt5lLGs C1E9hU0YNfh1mUcN1Vv4EULaPDmG05sbJYhenHrAp2fKbBj9tsLKp1ue36cnPuZx6YGpdoxe NnhfFsQJwxMZeUomow48HS9MNujyMJXNPavzRxEnF70UFyABAWQIVJm/8Vh2g9Hpxh0WEmJS j6D2zyNHocXAXN6O9hyD81UYO6hEsNqwirPFPwSW4WeYXcUjQ6FYW7/rcN1xmPpWOHbGyXEM KkvOFSCCcCGjoGnDz97mkFKwjg7vykWkL+TPv+Db+RAZDa3dWswuF5Bh0PhcykoOwlrptONE H+juKeOy7AfDpjeOd1r4ULp23m4F0gsMvTiLZ2Gx5R6rcIFfA618lj1hW29xOMsRtG+CPRSQ LQjq3xU5RGHQPzDmuMoZCjfnMfZMEejyHfukoW6lDWM5Etb1zVx2Ob8RdLSbeUXIp2Jfgop9 CSr2JahGeD1yY1QaRRKjOaEKDtDIFJqMtKSABKXCgHZ/kq9fB5quvmBEJIEkTqK/ir5YMVeW qclWGBEQuMRV9Fi90xIlyrJzGLXypjpDzmiMyJPgSNxFcUHFsWIySZbOpDKMilHvTTFC4JGL LhH5r5vvvg/QRY4E3lCeTPiydfGnr6C2putOzngWrdtSdcdbQ5WJufKnMUucoTMT4R+Sjktt 1+caomyG4ofh2ltN1oUrszJmxHXBLai3NlSJ0o/E4E4zp8qavK5Jn4SsFEXUFa9+GipMrbH5 f7/asab77B1Nyq0HgroT9IdTSAlHkywL9sXVGtl/ecSUTkUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t9jQd3V5QcjDPY9UrX4O+kYu8WkJ++Z LX62b2Gy2PT4GqvFsR2PmCwu75rDZnFo6l5Gi/29G5gsTl3/zGZxZtUtdgcuj8vXLjJ7/P41 idHj/Y1Wdo8HU/8zeeycdZfdY/OSeo8rJ5pYPY7f2M7k8XmTXABnlJtNRmpiSmqRQmpecn5K Zl66rVJoiJuuhZJCXmJuqq1ShK5vSJCSQlliTimQZ2SABhycA9yDlfTtEtwyNnU0MRX8F6/Y dWcCSwPjCqEuRk4OCQETiVNP5jJB2GISF+6tZ+ti5OIQEpjFKDHp11FmCOcro8TdE2sYQarY BKwkJravArNFgLqPHfzCAlLELHCFSWLW8pVAozg4hAU8JTb80gGpYRFQlbh74SxYPa+AlkTb k+XsILaogJfEln3tYOWcAtYS65eoQuyaziix4P0DqHpBiR+T77GA2MwC8hL79k9lhbC1JNbv PM40gRHoTISyWUjKZiEpW8DIvIpRIrUguaA4KT3XKC+1XK84Mbe4NC9dLzk/dxMjOFKfSe9g PLzL/RCjAAejEg/vh9yDEUKsiWXFlbmHGCU4mJVEeGcUAYV4UxIrq1KL8uOLSnNSiw8xmgI9 OJFZSjQ5H5hE8kriDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhPLEnNTk0tSC2C6WPi4JRqYMwr Ue3gOXf60BL1lG25L98yit5r4yo3bPn80/Hfh1NSazp5rsZ9UCtyzPwq9kH3durFe4uXV0v1 WhlruZ2cM2mr7sPIhtPe5XPecP1gETm28Vb64S5eq7qPOVNZbxzalfTt7EsZrqhl9yp3PVMT +by7oYcnoHfDtcchqeVP3K33711dJZs4pU+JpTgj0VCLuag4EQC5Z3s26gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170309154131epcas5p1f9c668855ee33c1634d4491d8664848b X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170309154131epcas5p1f9c668855ee33c1634d4491d8664848b X-RootMTR: 20170309154131epcas5p1f9c668855ee33c1634d4491d8664848b References: <1467991490-24895-1-git-send-email-b.zolnierkie@samsung.com> <3001681.2O13sqAj0p@amdc3058> <20170309150829.GM21222@n2100.armlinux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, March 09, 2017 03:08:29 PM Russell King - ARM Linux wrote: > On Thu, Mar 09, 2017 at 03:57:37PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Thursday, March 09, 2017 02:51:47 PM Russell King - ARM Linux wrote: > > > On Thu, Mar 09, 2017 at 03:42:49PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > > > > > Hi, > > > > > > > > On Thursday, March 09, 2017 01:57:15 PM Russell King - ARM Linux wrote: > > > > > On Thu, Mar 09, 2017 at 03:24:56PM +0300, Sergei Shtylyov wrote: > > > > > > On 03/09/2017 03:20 PM, Sekhar Nori wrote: > > > > > > > > > > > > >[...] > > > > > > > > > > > > >>>diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c > > > > > > >>>b/arch/arm/mach-davinci/board-dm644x-evm.c > > > > > > >>>index 023480b75244..60a1f23890cd 100644 > > > > > > >>>--- a/arch/arm/mach-davinci/board-dm644x-evm.c > > > > > > >>>+++ b/arch/arm/mach-davinci/board-dm644x-evm.c > > > > > > >>>@@ -744,7 +744,7 @@ static int davinci_phy_fixup(struct phy_device > > > > > > >>>*phydev) > > > > > > >>> return 0; > > > > > > >>> } > > > > > > >>> > > > > > > >>>-#define HAS_ATA IS_ENABLED(CONFIG_BLK_DEV_PALMCHIP_BK3710) > > > > > > >>>+#define HAS_ATA IS_ENABLED(CONFIG_PATA_BK3710) > > > > > > >> > > > > > > >> I think it would be more correct to check for both libata and IDE > > > > > > >>drivers here... > > > > > > > > > > > > > >As I understand, the plan is to remove the IDE driver soon. > > > > > > > > > > > > I'm not sure DaveM would support any removals in drivers/ide/. He has > > > > > > explicitly expressed his will to maintain the IDE driuver forever. > > > > > > > > > > As I keep saying, there are ARM machines where the IDE driver works but > > > > > the PATA driver doesn't. EBSA110's PCMCIA slots for instance. > > > > > > > > Please be more specific, I'll be happy to help with migrating this > > > > machines to libata PATA. > > > > > > > > BTW the example you're giving has never worked with the old IDE > > > > driver in the upstream kernel. > > > > > > That's where you are wrong. It worked for 10+ years with no > > > modifications in the upstream IDE driver or ide-cs driver - only the > > > patch I quoted was required. > > > > ..and the patch you quoted is in which upstream kernel version exactly? > > I don't claim that it works with the upstream kernel as a whole. I claim > that it works with the ide-cs driver _unmodified_ in the upstream kernel, > but with a simple two line patch which is private to the ARM architecture. > > Please pay attention to what I write, thanks. Out-of-tree patches are on their own, as kernel evolves they need to adapt, nothing new here. For 10+ years you were just extremely lucky with your out-of-tree patch. 8) Anyway, if you ever get to running current upstream on your EBSA110 please ping me and I will provide you with the draft pata_pcmcia patch to make EBSA110 work with libata. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics