From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39A57C433B4 for ; Wed, 21 Apr 2021 20:30:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC28E6144D for ; Wed, 21 Apr 2021 20:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245642AbhDUUav (ORCPT ); Wed, 21 Apr 2021 16:30:51 -0400 Received: from namei.org ([65.99.196.166]:48318 "EHLO mail.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240021AbhDUUat (ORCPT ); Wed, 21 Apr 2021 16:30:49 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.namei.org (Postfix) with ESMTPS id C698416D4; Wed, 21 Apr 2021 20:26:23 +0000 (UTC) Date: Thu, 22 Apr 2021 06:26:23 +1000 (AEST) From: James Morris To: Greg Kroah-Hartman cc: linux-kernel@vger.kernel.org, Kangjie Lu , Mika Westerberg Subject: Re: [PATCH 116/190] Revert "thunderbolt: property: Fix a NULL pointer dereference" In-Reply-To: <20210421130105.1226686-117-gregkh@linuxfoundation.org> Message-ID: <3821882d-22c4-5dc5-2df9-ae2d5e8fc2a@namei.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-117-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Apr 2021, Greg Kroah-Hartman wrote: > This reverts commit 106204b56f60abf1bead7dceb88f2be3e34433da. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu > Cc: Mika Westerberg > Signed-off-by: Greg Kroah-Hartman > --- > drivers/thunderbolt/property.c | 5 ----- > 1 file changed, 5 deletions(-) The original patch looks correct. Reviewed-by: James Morris > > diff --git a/drivers/thunderbolt/property.c b/drivers/thunderbolt/property.c > index ee76449524a3..b2f0d6386cee 100644 > --- a/drivers/thunderbolt/property.c > +++ b/drivers/thunderbolt/property.c > @@ -548,11 +548,6 @@ int tb_property_add_data(struct tb_property_dir *parent, const char *key, > > property->length = size / 4; > property->value.data = kzalloc(size, GFP_KERNEL); > - if (!property->value.data) { > - kfree(property); > - return -ENOMEM; > - } > - > memcpy(property->value.data, buf, buflen); > > list_add_tail(&property->list, &parent->properties); > -- > 2.31.1 > -- James Morris