From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Yabin Cui <yabinc@google.com>, Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@arm.com>, Leo Yan <leo.yan@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: tmc-etr: Don't fail probe when non-secure access is disabled
Date: Sun, 27 Aug 2023 22:37:38 +0100 [thread overview]
Message-ID: <382193a4-4f30-d804-47da-a9c705b6bee5@arm.com> (raw)
In-Reply-To: <20230825233930.1875819-1-yabinc@google.com>
On 26/08/2023 00:39, Yabin Cui wrote:
> Because the non-secure access can be enabled later on some devices.
How can this be enabled ? Why not enable it before probing the ETR ?
How can a user know if this has been done or not ? It is asking for
trouble to continue without this.
Suzuki
>
> Signed-off-by: Yabin Cui <yabinc@google.com>
> ---
> drivers/hwtracing/coresight/coresight-tmc-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c
> index c106d142e632..5ebfd12b627b 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-core.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c
> @@ -370,7 +370,7 @@ static int tmc_etr_setup_caps(struct device *parent, u32 devid, void *dev_caps)
> struct tmc_drvdata *drvdata = dev_get_drvdata(parent);
>
> if (!tmc_etr_has_non_secure_access(drvdata))
> - return -EACCES;
> + dev_warn(parent, "TMC ETR doesn't have non-secure access\n");
>
> /* Set the unadvertised capabilities */
> tmc_etr_init_caps(drvdata, (u32)(unsigned long)dev_caps);
next prev parent reply other threads:[~2023-08-27 21:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 23:39 [PATCH] coresight: tmc-etr: Don't fail probe when non-secure access is disabled Yabin Cui
2023-08-27 21:37 ` Suzuki K Poulose [this message]
2023-08-29 21:16 ` Yabin Cui
2023-08-30 8:52 ` Suzuki K Poulose
2023-08-30 17:49 ` Yabin Cui
2023-08-31 10:05 ` Robin Murphy
2023-08-31 21:36 ` Yabin Cui
2023-09-01 11:13 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=382193a4-4f30-d804-47da-a9c705b6bee5@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=yabinc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).