From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A2EDC433E6 for ; Tue, 5 Jan 2021 16:35:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4F8222CAE for ; Tue, 5 Jan 2021 16:35:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728602AbhAEQfQ (ORCPT ); Tue, 5 Jan 2021 11:35:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728521AbhAEQfP (ORCPT ); Tue, 5 Jan 2021 11:35:15 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B9DAC061793 for ; Tue, 5 Jan 2021 08:34:35 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id z5so28738005iob.11 for ; Tue, 05 Jan 2021 08:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eEsV5GjmLKE0KArAhzJzwbLWUdZGk09TCWvllXL+wYc=; b=TRFc9xF6N+Gx71MTz6M6NF5Po6d8blkVfoFTFC9J49EgAaRY5M5VaRdOQJQsqCT4v8 0LJtM1ATwRA7DXc4MaowjrtyQGqPnHwC+pOTtoflYlrFrg6bWJY97KBo1m6HbD/KszqJ yGk1bpIZBlJx5JXffjejYa8Lyfya3dyhOjsX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eEsV5GjmLKE0KArAhzJzwbLWUdZGk09TCWvllXL+wYc=; b=LdIDVjG+qhgKhr8beyAyR/C3slhYhWKGrGT+8yEvNS9qth8OgORXCQ8jF1B1U9KeWI nk+8He3fKu6uYW5fAC4YpyqtYbaF4keaKeyFVb+BOXbyRvo4Gcyv7Lm1JK38ImuPuE3F bbAz2RBCRQb79xnPxzWHd7NU4JmA9zuv5dzIYCTGTVw1S+jDzz9vk94vt8BG6YAsSNlh QdRfn35dTv6rnRT+AQTK6E+nue7IvjdveiZzKN9dSeJOhSjdJDFK6XacPVwVKr0E2UnR RJ/yD48P0Ha9WoZnv1sKLV3LCkZp5vH6KbBVGhmlRqQjU9zX/gG8vEUCHB/g6KnbHTYS FtnQ== X-Gm-Message-State: AOAM530W/mprfYlvhblueBqRFeCE2YhTm5xROZqUgLyW+lXtr3cunZyg G0HqXc8R62kkuUd+DP4sdFx1Pg== X-Google-Smtp-Source: ABdhPJyoENdD6Y7jK8od4+dyGrYt+P3X2XmyMb3keo0+VCokN+Y87ht4X1zlOfuzyfK+JsibUwltsg== X-Received: by 2002:a6b:6016:: with SMTP id r22mr63753744iog.93.1609864474805; Tue, 05 Jan 2021 08:34:34 -0800 (PST) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id l78sm55322ild.30.2021.01.05.08.34.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jan 2021 08:34:34 -0800 (PST) Subject: Re: [PATCH] kunit: tool: Force the use of the 'tty' console for UML To: Petr Mladek Cc: Andy Shevchenko , David Gow , Brendan Higgins , Senozhatsky , Sergey Senozhatsky , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Shuah Khan References: <20201222073900.3490607-1-davidgow@google.com> <20201222111102.GC4077@smile.fi.intel.com> <4ae7779c-15c5-0474-5840-44531dcf1d94@linuxfoundation.org> From: Shuah Khan Message-ID: <3828c7ee-52b0-42f9-5771-74ef9386756c@linuxfoundation.org> Date: Tue, 5 Jan 2021 09:34:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/5/21 9:21 AM, Petr Mladek wrote: > On Mon 2021-01-04 09:23:57, Shuah Khan wrote: >> On 12/22/20 4:11 AM, Andy Shevchenko wrote: >>> On Mon, Dec 21, 2020 at 11:39:00PM -0800, David Gow wrote: >>>> kunit_tool relies on the UML console outputting printk() output to the >>>> tty in order to get results. Since the default console driver could >>>> change, pass 'console=tty' to the kernel. >>>> >>>> This is triggered by a change[1] to use ttynull as a fallback console >>>> driver which -- by chance or by design -- seems to have changed the >>>> default console output on UML, breaking kunit_tool. While this may be >>>> fixed, we should be less fragile to such changes in the default. >>>> >>>> [1]: >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=757055ae8dedf5333af17b3b5b4b70ba9bc9da4e >>> >>> Reported-by: Andy Shevchenko >>> Tested-by: Andy Shevchenko >>> >> >> Thank you all. Now in linux-kselftest kunit-fixes branch. >> >> Will send this up for rc3. >> >> Sorry for the delay - have been away from the keyboard for a >> bit. > > JFYI, I am not sure that this is the right solution. I am > looking into it, see > https://lore.kernel.org/linux-kselftest/X%2FSRA1P8t+ONZFKb@alley/ > for more details. > Thanks Petr. I will hold off on sending the patch up to Linus and let you find a the right solution. thanks, -- Shuah