From: Liu Shixin <liushixin2@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yosry Ahmed <yosryahmed@google.com>,
Huang Ying <ying.huang@intel.com>,
Sachin Sant <sachinp@linux.ibm.com>,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] mm: vmscan: try to reclaim swapcache pages if no swap space
Date: Sat, 7 Oct 2023 14:26:32 +0800 [thread overview]
Message-ID: <38420ca8-9c83-bb06-041f-ce1cf1f084ef@huawei.com> (raw)
In-Reply-To: <20231004091853.9be5aa562f65e0305e06b14c@linux-foundation.org>
On 2023/10/5 0:18, Andrew Morton wrote:
> On Fri, 15 Sep 2023 16:34:17 +0800 Liu Shixin <liushixin2@huawei.com> wrote:
>
>> When spaces of swap devices are exhausted, only file pages can be
>> reclaimed. But there are still some swapcache pages in anon lru list.
>> This can lead to a premature out-of-memory.
>>
>> The problem is found with such step:
>>
>> Firstly, set a 9MB disk swap space, then create a cgroup with 10MB
>> memory limit, then runs an program to allocates about 15MB memory.
>>
>> The problem occurs occasionally, which may need about 100 times [1].
>>
>> Fix it by checking number of swapcache pages in can_reclaim_anon_pages().
>> If the number is not zero, return true and set swapcache_only to 1.
>> When scan anon lru list in swapcache_only mode, non-swapcache pages will
>> be skipped to isolate in order to accelerate reclaim efficiency.
>>
>> However, in swapcache_only mode, the scan count still increased when scan
>> non-swapcache pages because there are large number of non-swapcache pages
>> and rare swapcache pages in swapcache_only mode, and if the non-swapcache
>> is skipped and do not count, the scan of pages in isolate_lru_folios() can
>> eventually lead to hung task, just as Sachin reported [2].
>>
>> By the way, since there are enough times of memory reclaim before OOM, it
>> is not need to isolate too much swapcache pages in one times.
>>
> mhocko earlier suspected this might impact global reclaim. Have you
> looked into that further?
> .
Alreadly test the case of global reclaim using ltp testcases. In previous version,
the reclaim can stall in isolate_lru_folios() because I didn't count non-swapcache
pages into scan so it will waste too much times scanning non-swapcache pages.
In this version, I count non-swapcache pages into scan too and terminate when
scan reaches the threshold. So it will not stall in reclaim now.
prev parent reply other threads:[~2023-10-07 6:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 8:34 [PATCH v6] mm: vmscan: try to reclaim swapcache pages if no swap space Liu Shixin
2023-10-04 16:18 ` Andrew Morton
2023-10-07 6:26 ` Liu Shixin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38420ca8-9c83-bb06-041f-ce1cf1f084ef@huawei.com \
--to=liushixin2@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=sachinp@linux.ibm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).