From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751607AbdB0DOV (ORCPT ); Sun, 26 Feb 2017 22:14:21 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:43904 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbdB0DOT (ORCPT ); Sun, 26 Feb 2017 22:14:19 -0500 X-AuditID: b6c32a2e-f79d66d0000012ad-c6-58b39988aad7 Subject: Re: [PATCH 2/2] media: s5p-mfc: fix MMAP of mfc buffer during reqbufs To: Javier Martinez Canillas , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kyungmin.park@samsung.com, jtp.park@samsung.com, mchehab@kernel.org, mchehab@osg.samsung.com, hans.verkuil@cisco.com, krzk@kernel.org, kgene@kernel.org, Smitha T Murthy From: "pankaj.dubey" Message-id: <384899ef-4e7e-d7f5-8f4f-ef2f023cb681@samsung.com> Date: Mon, 27 Feb 2017 08:47:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-version: 1.0 In-reply-to: <81c11e69-b7eb-ccb5-a377-2848ec551274@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPKsWRmVeSWpSXmKPExsWy7bCmum7HzM0RBgdeaFgs+bmLyeLN2zVM FkfWXmWy6H/8mtni/PkN7BZnm96wW2x6fI3V4vKuOWwWPRu2slrMOL+PyWLZpj9MFqufVVjc 3bON0YHXY8rvjawem1Z1snlsXlLvsaX/LrtH35ZVjB6fN8kFsEVx2aSk5mSWpRbp2yVwZdw5 +Z214IVQxfxDq9gaGA/xdzFycEgImEjMX5XdxcgJZIpJXLi3nq2LkYtDSGApo8Sm6TdZIJxP jBJbvk5GcF52vGKDaDGROL3uDVTLTkaJGcvWgSXAqt68UQWxhQUCJGb2/mUFKRIR2Msose3d CWaQBLPAcUaJtZvcQGw2AX2J6Y+3gTXzCthJrDl0nA3kPhYBVYkFS7RAwqICERJH/39ggSgR lDg58wkLSAmngLPEtqYQiIkGEkcWzWGFsOUltr+dwwyyVkKgmV3i3br/7BBHu0hM/HmMGcIW lnh1fAtUXEri87u9bFANjBINW6ewQDgzGCUW7JzMBFFlL3HgyhwWCNtW4sjJiSyQgOSTuPFW EGIzn0Tv7ydQ5WoS35+fYYYo4ZXoaBOCCHtI7Ni1gmUCo9IsJO/MQvLDLCQ/LGBkXsUollpQ nJueWmxaYKxXnJhbXJqXrpecn7uJEZystPR2MP5b4H2IUYCDUYmHt8N3c4QQa2JZcWXuIUYJ DmYlEV5XkBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHeKIOJEUIC6YklqdmpqQWpRTBZJg5OqQZG d/FKz/Vh4qtFEtbLbiq8/1SyuDqpU2e2SYjHUWdR4TcLmN7JvDi2oeWAyvTtR+6t6OLl7ThY paQTKR1Y/eUOA7/udab2ktQFTtNClKL1rPtaazn3PeL4+V508f0FdYvUOdtfz5wjf8DNyuja 8u2fljIofNhqnmZp/ik05FT/NyOl5BsZkjeUWIozEg21mIuKEwGNQUVGUgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCIsWRmVeSWpSXmKPExsWy7bCSnK73zM0RBkcP61ks+bmLyeLN2zVM FkfWXmWy6H/8mtni/PkN7BZnm96wW2x6fI3V4vKuOWwWPRu2slrMOL+PyWLZpj9MFqufVVjc 3bON0YHXY8rvjawem1Z1snlsXlLvsaX/LrtH35ZVjB6fN8kFsEVx2aSk5mSWpRbp2yVwZdw5 +Z214IVQxfxDq9gaGA/xdzFyckgImEicXveGDcIWk7hwbz2QzcUhJLCdUeLH9KUsEAkNiY13 ljNB2MISK/89Z4co+sAosaT3O1i3sICfxMfmJ8wgtojAXkaJtTNtIYqmMEl87+kA62AWOM4o sffRXUaQKjYBfYnpj7eBdfMK2EmsOXQcyObgYBFQlViwRAvEFBWIkPjWxw5RIShxcuYTFpAw p4CzxLamEJAws4CexI7rv1ghbHmJ7W/nME9gFJqFpGMWkrJZSMoWMDKvYhRNLSjOTc8tLjDS K07MLS7NS9dLzs/dxAiOK62kHYybZoQfYhTgYFTi4bUI2hwhxJpYVlyZe4hRgoNZSYTX1Rco xJuSWFmVWpQfX1Sak1p8iFGag0VJnHd79YYIIYH0xJLU7NTUgtQimCwTB6dUA2Mwm6WJxjyR lzYa0Zo3D2mGuHxx3m4762nZ/9LimswZ244zbWCSPDjp3iqTCSe9zO/aziiNX5a41sVFZqFr xcpJ9ScEFA0r1ijKeYSt3XrzeoK+5lk302OZ+3x6Cq/97mL5bNwauOiFMaMN81PL0y6XxWsa 1VXjzwt1mKU9XV7Gn9N29tJZKyWW4oxEQy3mouJEAEkeHeSnAgAA X-CMS-MailID: 20170227031416epcas5p4e81625994f6dbb4815208c8d0332575c X-Msg-Generator: CA X-Sender-IP: 182.195.40.14 X-Local-Sender: =?UTF-8?B?7YyQ7Lm07KaIG1NTSVItVHVybiBLZXkgU29sdXRpb25zGw==?= =?UTF-8?B?7IK87ISx7KCE7J6QGy4vQ2hpZWYgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?UEFOS0FKIEtVTUFSIERVQkVZG1NTSVItVHVybiBLZXkgU29s?= =?UTF-8?B?dXRpb25zG1NhbXN1bmcgRWxlY3Ryb25pY3MbLi9DaGllZiBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElEMDdJRDAxMDk5Nw==?= X-MTR: 20170227031416epcas5p4e81625994f6dbb4815208c8d0332575c X-EPHeader: CA CMS-TYPE: 105P X-Auth-Email: pankaj.dubey@samsung.com X-HopCount: 7 X-CMS-RootMailID: 20170224194302epcas2p2edea64bf7b2fc89ee97b6f5391b2dad0 X-RootMTR: 20170224194302epcas2p2edea64bf7b2fc89ee97b6f5391b2dad0 References: <1481888915-19624-1-git-send-email-pankaj.dubey@samsung.com> <1481888915-19624-3-git-send-email-pankaj.dubey@samsung.com> <81c11e69-b7eb-ccb5-a377-2848ec551274@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Javier, On Saturday 25 February 2017 01:12 AM, Javier Martinez Canillas wrote: > Hello Pankaj, > > On 12/16/2016 08:48 AM, Pankaj Dubey wrote: >> From: Smitha T Murthy >> >> It has been observed on ARM64 based Exynos SoC, if IOMMU is not enabled >> and we try to use reserved memory for MFC, reqbufs fails with below >> mentioned error >> --------------------------------------------------------------------------- >> V4L2 Codec decoding example application >> Kamil Debski >> Copyright 2012 Samsung Electronics Co., Ltd. >> >> Opening MFC. >> (mfc.c:mfc_open:58): MFC Info (/dev/video0): driver="s5p-mfc" \ >> bus_info="platform:12c30000.mfc0" card="s5p-mfc-dec" fd=0x4[ >> 42.339165] Remapping memory failed, error: -6 >> >> MFC Open Success. >> (main.c:main:711): Successfully opened all necessary files and devices >> (mfc.c:mfc_dec_setup_output:103): Setup MFC decoding OUTPUT buffer \ >> size=4194304 (requested=4194304) >> (mfc.c:mfc_dec_setup_output:120): Number of MFC OUTPUT buffers is 2 \ >> (requested 2) >> >> [App] Out buf phy : 0x00000000, virt : 0xffffffff >> Output Length is = 0x300000 >> Error (mfc.c:mfc_dec_setup_output:145): Failed to MMAP MFC OUTPUT buffer >> ------------------------------------------------------------------------- >> This is because the device requesting for memory is mfc0.left not the parent mfc0. >> Hence setting of alloc_devs need to be done only if IOMMU is enabled >> and in that case both the left and right device is treated as mfc0 only. >> > > I see, so likely you were facing the issue described in patch 1/2 after this > patch since the driver doesn't set alloc_devs when IOMMU is disabled, right? > Yes. > In any case, I guess these patches have been superseded by Marek's series[0] > so they are no longer needed? > Yes, these patches have been superseded but now by Marek's series. I missed to check Marek's series [0] due to some official assignment, but we followed up our patch series with Marek, and fix was provided in of_reserved_mem.c via patch [1] which has been accepted and merged as well. I will try to find out some time and test Marek's patch series [0]. [1]: https://patchwork.kernel.org/patch/9482499/ Thanks, Pankaj Dubey > [0]: https://www.spinics.net/lists/linux-media/msg111156.html > > Best regards, >