linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: Convert arm,i2c-versatile to DT schema
Date: Tue, 7 Jun 2022 14:16:13 +0200	[thread overview]
Message-ID: <3849248a-fe0e-157a-21dc-62c1c91ae204@linaro.org> (raw)
In-Reply-To: <20220606184339.1058557-1-robh@kernel.org>

On 06/06/2022 20:43, Rob Herring wrote:
> Convert the arm,i2c-versatile binding to DT schema format.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/i2c/arm,i2c-versatile.yaml       | 29 +++++++++++++++++++
>  .../devicetree/bindings/i2c/i2c-versatile.txt | 10 -------
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 30 insertions(+), 11 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/i2c/arm,i2c-versatile.yaml
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-versatile.txt
> 
> diff --git a/Documentation/devicetree/bindings/i2c/arm,i2c-versatile.yaml b/Documentation/devicetree/bindings/i2c/arm,i2c-versatile.yaml
> new file mode 100644
> index 000000000000..e58465d1b0c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/arm,i2c-versatile.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/arm,i2c-versatile.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: I2C Controller on ARM Ltd development platforms
> +
> +maintainers:
> +  - Linus Walleij <linus.walleij@linaro.org>
> +
> +allOf:
> +  - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: arm,versatile-i2c
> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +...
> +
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-versatile.txt b/Documentation/devicetree/bindings/i2c/i2c-versatile.txt
> deleted file mode 100644
> index 361d31c51b6f..000000000000
> --- a/Documentation/devicetree/bindings/i2c/i2c-versatile.txt
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -i2c Controller on ARM Versatile platform:
> -
> -Required properties:
> -- compatible : Must be "arm,versatile-i2c";
> -- reg
> -- #address-cells = <1>;
> -- #size-cells = <0>;
> -
> -Optional properties:
> -- Child nodes conforming to i2c bus binding
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a6d3bd9d2a8d..ecc0907e312a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1520,7 +1520,7 @@ F:	Documentation/devicetree/bindings/arm/arm,versatile.yaml
>  F:	Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml
>  F:	Documentation/devicetree/bindings/auxdisplay/arm,versatile-lcd.yaml
>  F:	Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> -F:	Documentation/devicetree/bindings/i2c/i2c-versatile.txt
> +F:	Documentation/devicetree/bindings/i2c/arn,i2c-versatile.yaml

typo:
s/arn/arm/

With that:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

  reply	other threads:[~2022-06-07 12:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 18:43 [PATCH] dt-bindings: i2c: Convert arm,i2c-versatile to DT schema Rob Herring
2022-06-07 12:16 ` Krzysztof Kozlowski [this message]
2022-06-08 19:48 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3849248a-fe0e-157a-21dc-62c1c91ae204@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).