* [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices
@ 2021-12-16 11:55 Andrej Picej
2021-12-16 11:55 ` [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly Andrej Picej
2022-01-26 9:24 ` [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices Shawn Guo
0 siblings, 2 replies; 7+ messages in thread
From: Andrej Picej @ 2021-12-16 11:55 UTC (permalink / raw)
To: shawnguo, robh+dt, s.hauer, devicetree
Cc: festevam, kernel, linux-kernel, y.bas
phyFLEX PMIC DA9063 has also RTC and watchdog support. Add both
mfd subdevices so they can be used.
Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
index f3236204cb5a..2ec154756bbc 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
@@ -205,6 +205,14 @@ vdd_mx6_high_reg: ldo11 {
regulator-always-on;
};
};
+
+ pmic_rtc: rtc {
+ compatible = "dlg,da9063-rtc";
+ };
+
+ da9063_wdog: wdt {
+ compatible = "dlg,da9063-watchdog";
+ };
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly
2021-12-16 11:55 [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices Andrej Picej
@ 2021-12-16 11:55 ` Andrej Picej
2022-01-26 9:27 ` Shawn Guo
2022-01-26 9:24 ` [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices Shawn Guo
1 sibling, 1 reply; 7+ messages in thread
From: Andrej Picej @ 2021-12-16 11:55 UTC (permalink / raw)
To: shawnguo, robh+dt, s.hauer, devicetree
Cc: festevam, kernel, linux-kernel, y.bas
From: Yunus Bas <y.bas@phytec.de>
The proper way to handle partly used MFD devices are to describe all MFD
subdevices in the devicetree and disable the not used ones. This
suppresses any warnings that may arise as a result.
Signed-off-by: Yunus Bas <y.bas@phytec.de>
Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 5 +++++
arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 10 ++++++++++
2 files changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
index 2ec154756bbc..3590f439adf5 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
@@ -213,6 +213,11 @@ pmic_rtc: rtc {
da9063_wdog: wdt {
compatible = "dlg,da9063-watchdog";
};
+
+ onkey {
+ compatible = "dlg,da9063-onkey";
+ status = "disabled";
+ };
};
};
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
index 94b254bfd054..28a805384668 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
@@ -116,6 +116,16 @@ watchdog {
dlg,use-sw-pm;
};
+ thermal {
+ compatible = "dlg,da9062-thermal";
+ status = "disabled";
+ };
+
+ gpio {
+ compatible = "dlg,da9062-gpio";
+ status = "disabled";
+ };
+
regulators {
vdd_arm: buck1 {
regulator-name = "vdd_arm";
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices
2021-12-16 11:55 [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices Andrej Picej
2021-12-16 11:55 ` [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly Andrej Picej
@ 2022-01-26 9:24 ` Shawn Guo
2022-01-27 6:28 ` Andrej Picej
1 sibling, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2022-01-26 9:24 UTC (permalink / raw)
To: Andrej Picej
Cc: robh+dt, s.hauer, devicetree, festevam, kernel, linux-kernel, y.bas
On Thu, Dec 16, 2021 at 12:55:28PM +0100, Andrej Picej wrote:
> phyFLEX PMIC DA9063 has also RTC and watchdog support. Add both
> mfd subdevices so they can be used.
>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> ---
> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index f3236204cb5a..2ec154756bbc 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -205,6 +205,14 @@ vdd_mx6_high_reg: ldo11 {
> regulator-always-on;
> };
> };
> +
> + pmic_rtc: rtc {
Maybe a more specific label like the following?
da9063_rtc: rtc
And it's more aligned with da9063_wdog below.
> + compatible = "dlg,da9063-rtc";
> + };
> +
> + da9063_wdog: wdt {
watchdog for the node name.
Shawn
> + compatible = "dlg,da9063-watchdog";
> + };
> };
> };
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly
2021-12-16 11:55 ` [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly Andrej Picej
@ 2022-01-26 9:27 ` Shawn Guo
2022-01-27 6:29 ` Andrej Picej
0 siblings, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2022-01-26 9:27 UTC (permalink / raw)
To: Andrej Picej
Cc: robh+dt, s.hauer, devicetree, festevam, kernel, linux-kernel, y.bas
On Thu, Dec 16, 2021 at 12:55:29PM +0100, Andrej Picej wrote:
> From: Yunus Bas <y.bas@phytec.de>
>
> The proper way to handle partly used MFD devices are to describe all MFD
> subdevices in the devicetree and disable the not used ones. This
> suppresses any warnings that may arise as a result.
>
> Signed-off-by: Yunus Bas <y.bas@phytec.de>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Use subject prefix like
ARM: dts: imx6qdl-phytec: ...
Shawn
> ---
> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 5 +++++
> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 10 ++++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 2ec154756bbc..3590f439adf5 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -213,6 +213,11 @@ pmic_rtc: rtc {
> da9063_wdog: wdt {
> compatible = "dlg,da9063-watchdog";
> };
> +
> + onkey {
> + compatible = "dlg,da9063-onkey";
> + status = "disabled";
> + };
> };
> };
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> index 94b254bfd054..28a805384668 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -116,6 +116,16 @@ watchdog {
> dlg,use-sw-pm;
> };
>
> + thermal {
> + compatible = "dlg,da9062-thermal";
> + status = "disabled";
> + };
> +
> + gpio {
> + compatible = "dlg,da9062-gpio";
> + status = "disabled";
> + };
> +
> regulators {
> vdd_arm: buck1 {
> regulator-name = "vdd_arm";
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices
2022-01-26 9:24 ` [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices Shawn Guo
@ 2022-01-27 6:28 ` Andrej Picej
2022-01-28 3:55 ` Shawn Guo
0 siblings, 1 reply; 7+ messages in thread
From: Andrej Picej @ 2022-01-27 6:28 UTC (permalink / raw)
To: Shawn Guo
Cc: robh+dt, s.hauer, devicetree, festevam, kernel, linux-kernel, y.bas
Hi Shawn,
On 26. 01. 22 10:24, Shawn Guo wrote:
> On Thu, Dec 16, 2021 at 12:55:28PM +0100, Andrej Picej wrote:
>> phyFLEX PMIC DA9063 has also RTC and watchdog support. Add both
>> mfd subdevices so they can be used.
>>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>> ---
>> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> index f3236204cb5a..2ec154756bbc 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> @@ -205,6 +205,14 @@ vdd_mx6_high_reg: ldo11 {
>> regulator-always-on;
>> };
>> };
>> +
>> + pmic_rtc: rtc {
>
> Maybe a more specific label like the following?
>
> da9063_rtc: rtc
>
> And it's more aligned with da9063_wdog below.
>
>> + compatible = "dlg,da9063-rtc";
>> + };
>> +
>> + da9063_wdog: wdt {
>
> watchdog for the node name.
>
I'll apply your suggestions and send v2.
Do you agree that I also change the commit subject line to "ARM: dts:
imx6qdl-phytec: ...", as you suggested in patch 2/2?
Thanks for your review.
Andrej
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly
2022-01-26 9:27 ` Shawn Guo
@ 2022-01-27 6:29 ` Andrej Picej
0 siblings, 0 replies; 7+ messages in thread
From: Andrej Picej @ 2022-01-27 6:29 UTC (permalink / raw)
To: Shawn Guo
Cc: robh+dt, s.hauer, devicetree, festevam, kernel, linux-kernel, y.bas
On 26. 01. 22 10:27, Shawn Guo wrote:
> On Thu, Dec 16, 2021 at 12:55:29PM +0100, Andrej Picej wrote:
>> From: Yunus Bas <y.bas@phytec.de>
>>
>> The proper way to handle partly used MFD devices are to describe all MFD
>> subdevices in the devicetree and disable the not used ones. This
>> suppresses any warnings that may arise as a result.
>>
>> Signed-off-by: Yunus Bas <y.bas@phytec.de>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>
> Use subject prefix like
>
> ARM: dts: imx6qdl-phytec: ...
>
> Shawn
Will send a v2 with this change.
Thanks.
Andrej
>
>> ---
>> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 5 +++++
>> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 10 ++++++++++
>> 2 files changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> index 2ec154756bbc..3590f439adf5 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> @@ -213,6 +213,11 @@ pmic_rtc: rtc {
>> da9063_wdog: wdt {
>> compatible = "dlg,da9063-watchdog";
>> };
>> +
>> + onkey {
>> + compatible = "dlg,da9063-onkey";
>> + status = "disabled";
>> + };
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> index 94b254bfd054..28a805384668 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> @@ -116,6 +116,16 @@ watchdog {
>> dlg,use-sw-pm;
>> };
>>
>> + thermal {
>> + compatible = "dlg,da9062-thermal";
>> + status = "disabled";
>> + };
>> +
>> + gpio {
>> + compatible = "dlg,da9062-gpio";
>> + status = "disabled";
>> + };
>> +
>> regulators {
>> vdd_arm: buck1 {
>> regulator-name = "vdd_arm";
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices
2022-01-27 6:28 ` Andrej Picej
@ 2022-01-28 3:55 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2022-01-28 3:55 UTC (permalink / raw)
To: Andrej Picej
Cc: robh+dt, s.hauer, devicetree, festevam, kernel, linux-kernel, y.bas
On Thu, Jan 27, 2022 at 07:28:27AM +0100, Andrej Picej wrote:
> Hi Shawn,
>
> On 26. 01. 22 10:24, Shawn Guo wrote:
> > On Thu, Dec 16, 2021 at 12:55:28PM +0100, Andrej Picej wrote:
> > > phyFLEX PMIC DA9063 has also RTC and watchdog support. Add both
> > > mfd subdevices so they can be used.
> > >
> > > Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> > > ---
> > > arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > > index f3236204cb5a..2ec154756bbc 100644
> > > --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > > +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> > > @@ -205,6 +205,14 @@ vdd_mx6_high_reg: ldo11 {
> > > regulator-always-on;
> > > };
> > > };
> > > +
> > > + pmic_rtc: rtc {
> >
> > Maybe a more specific label like the following?
> >
> > da9063_rtc: rtc
> >
> > And it's more aligned with da9063_wdog below.
> >
> > > + compatible = "dlg,da9063-rtc";
> > > + };
> > > +
> > > + da9063_wdog: wdt {
> >
> > watchdog for the node name.
> >
>
> I'll apply your suggestions and send v2.
> Do you agree that I also change the commit subject line to "ARM: dts:
> imx6qdl-phytec: ...", as you suggested in patch 2/2?
Yeah, even better, thanks!
Shawn
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-01-28 3:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-16 11:55 [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices Andrej Picej
2021-12-16 11:55 ` [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly Andrej Picej
2022-01-26 9:27 ` Shawn Guo
2022-01-27 6:29 ` Andrej Picej
2022-01-26 9:24 ` [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices Shawn Guo
2022-01-27 6:28 ` Andrej Picej
2022-01-28 3:55 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).