From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936683AbdAKIxn (ORCPT <rfc822;w@1wt.eu>);
        Wed, 11 Jan 2017 03:53:43 -0500
Received: from mx1.molgen.mpg.de ([141.14.17.9]:51305 "EHLO mx1.molgen.mpg.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751503AbdAKIxm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Jan 2017 03:53:42 -0500
Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3
To: Jan Niehusmann <jan@gondor.com>
References: <7b1ba8e4-03b2-8a73-603b-63cce6403c31@molgen.mpg.de>
 <20170110204331.GA3974@x61s.reliablesolutions.de>
 <20170110222437.GA3022@x61s.reliablesolutions.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thorsten Leemhuis <linux@leemhuis.info>,
        Daniel Blueman <daniel@quora.org>, Len Brown <len.brown@intel.com>,
        Tomas Winkler <tomas.winkler@intel.com>,
        Alexander Usyskin <alexander.usyskin@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
From: Paul Menzel <pmenzel@molgen.mpg.de>
Message-ID: <384df4ea-8a3e-0db3-c057-e8ef46912504@molgen.mpg.de>
Date: Wed, 11 Jan 2017 09:53:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <20170110222437.GA3022@x61s.reliablesolutions.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dear Linux folks,


On 01/10/17 23:24, Jan Niehusmann wrote:
> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
>> And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
>> FW"
>
> Indeed, just disabling the FIXUP implemented by that commit fixes
> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
>
> (For the addressees newly added to cc, it seems like the mentioned
> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
>
> --- a/drivers/misc/mei/bus-fixup.c
> +++ b/drivers/misc/mei/bus-fixup.c
> @@ -406,3 +406,3 @@ static struct mei_fixup {
>         MEI_FIXUP(MEI_UUID_WD, mei_wd),
> -       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> +//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
>  };
>
>
> I don't know what this may break, as the description of 7279b23 just
> says:
> "This workaround was added to support other broken OS and we need to
> follow here."
>
> Unless there is a better justification, I think the commit should be
> reverted, for now.

Somebody else already created the bug 192051 in the Linux Kernel Bug 
Tracker [1].


Kind regards,

Paul


[1] https://bugzilla.kernel.org/show_bug.cgi?id=192051
     "[Bug 192051] [bisected] No hibernation/suspend/shutdown after 
commit 7279b238badec09efd0545293e64c21feee97f73"