From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751368AbeFDSb5 (ORCPT ); Mon, 4 Jun 2018 14:31:57 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:38362 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbeFDSb4 (ORCPT ); Mon, 4 Jun 2018 14:31:56 -0400 X-Google-Smtp-Source: ADUXVKLRRAnFD/0Yufu+Z8aXN2SM4nOYboCEWa9RToaDW2rznv6f+7ecb+CFto26rH1JOaWrNkbIAw== Subject: Re: [PATCH v3 03/10] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063 To: Lee Jones Cc: linux-kernel@vger.kernel.org, Marek Vasut , Geert Uytterhoeven , Mark Brown , Steve Twiss , Wolfram Sang , linux-renesas-soc@vger.kernel.org References: <20180602101155.26375-1-marek.vasut+renesas@gmail.com> <20180602101155.26375-3-marek.vasut+renesas@gmail.com> <20180604122658.GC21163@dell> From: Marek Vasut Message-ID: <3853ee6e-86a7-793e-c633-fc9c2910976f@gmail.com> Date: Mon, 4 Jun 2018 20:31:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180604122658.GC21163@dell> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2018 02:26 PM, Lee Jones wrote: > On Sat, 02 Jun 2018, Marek Vasut wrote: > >> The PMIC_DA9063 is a complete misnomer, it denotes the value of the >> DA9063 chip ID register, so rename it as such. It is also the value >> of chip ID register of DA9063L though, so drop the enum as all the >> DA9063 "models" share the same chip ID and thus the distinction will >> have to be made using DT or otherwise. >> >> Signed-off-by: Marek Vasut >> Cc: Geert Uytterhoeven >> Cc: Lee Jones >> Cc: Mark Brown >> Cc: Steve Twiss >> Cc: Wolfram Sang >> Cc: linux-renesas-soc@vger.kernel.org >> Acked-by: Mark Brown >> Reviewed-by: Geert Uytterhoeven >> --- >> V2: No change >> V3: No change >> --- >> drivers/mfd/da9063-core.c | 2 +- >> drivers/mfd/da9063-i2c.c | 2 +- >> drivers/regulator/da9063-regulator.c | 2 +- >> include/linux/mfd/da9063/core.h | 4 +--- >> 4 files changed, 4 insertions(+), 6 deletions(-) > > For my own reference: > Acked-for-MFD-by: Lee Jones Thanks. Any other comments before I submit the next round in a few days? -- Best regards, Marek Vasut