From: Ezequiel Garcia <ezequiel@collabora.com>
To: Doug Anderson <dianders@chromium.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Sandy Huang" <hjc@rock-chips.com>,
kernel@collabora.com, "Sean Paul" <seanpaul@chromium.org>,
"Boris Brezillon" <boris.brezillon@collabora.com>,
"Jacopo Mondi" <jacopo@jmondi.org>,
"Ilia Mirkin" <imirkin@alum.mit.edu>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: display: rockchip: document VOP gamma LUT address
Date: Thu, 20 Jun 2019 13:56:23 -0300 [thread overview]
Message-ID: <385c93321be1ec5875769d1a825d0fcd44677959.camel@collabora.com> (raw)
In-Reply-To: <CAD=FV=UpZAjrWkQ7qj5Wo2tf2wkg5Q-34Sun0MOtYLBAwY731Q@mail.gmail.com>
On Thu, 2019-06-20 at 09:43 -0700, Doug Anderson wrote:
> Hi,
>
> On Tue, Jun 18, 2019 at 2:43 PM Ezequiel Garcia <ezequiel@collabora.com> wrote:
> > Add the register specifier description for an
> > optional gamma LUT address.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > ---
> > .../bindings/display/rockchip/rockchip-vop.txt | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-
> > vop.txt
> > index 4f58c5a2d195..97ad78cc7e03 100644
> > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> > @@ -20,6 +20,13 @@ Required properties:
> > "rockchip,rk3228-vop";
> > "rockchip,rk3328-vop";
> >
> > +- reg: Must contain one entry corresponding to the base address and length
> > + of the register space. Can optionally contain a second entry
> > + corresponding to the CRTC gamma LUT address.
> > +
> > +- reg-names: "base" for the base register space. If present, the CRTC
> > + gamma LUT name should be "lut".
>
> As per Rob Herring, current suggestion is to avoid reg-names when
> possible. The code should just look for the presence of a 2nd entry
> and assume that if it's there that it's the lut range. Full context:
>
> > https://lore.kernel.org/lkml/CAL_Jsq+MMunmVWqeW9v2RyzsMKP+=kMzeTHNMG4JDHM7Fy0HBg@mail.gmail.com/
>
Oh, that's news to me. I was assuming having reg-names was preferred.
Thanks for the feedback, I'll send a new version.
next prev parent reply other threads:[~2019-06-20 16:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 21:34 [PATCH 0/3] RK3288 Gamma LUT Ezequiel Garcia
2019-06-18 21:34 ` [PATCH 1/3] dt-bindings: display: rockchip: document VOP gamma LUT address Ezequiel Garcia
2019-06-20 16:43 ` Doug Anderson
2019-06-20 16:56 ` Ezequiel Garcia [this message]
2019-06-18 21:34 ` [PATCH 2/3] drm/rockchip: Add optional support for CRTC gamma LUT Ezequiel Garcia
2019-06-18 21:47 ` Ilia Mirkin
2019-06-18 22:09 ` Ezequiel Garcia
2019-06-18 22:18 ` Heiko Stübner
2019-06-20 16:02 ` Ezequiel Garcia
2019-06-20 17:25 ` Doug Anderson
2019-06-21 15:52 ` Ezequiel Garcia
2019-06-21 8:22 ` Jacopo Mondi
2019-06-21 15:59 ` Ezequiel Garcia
2019-06-18 21:34 ` [PATCH 3/3] ARM: dts: rockchip: Add RK3288 VOP gamma LUT address Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=385c93321be1ec5875769d1a825d0fcd44677959.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=imirkin@alum.mit.edu \
--cc=jacopo@jmondi.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).