From: 刘永志 <lyz_cs@pku.edu.cn>
To: "rafael j. wysocki" <rafael@kernel.org>
Cc: "greg kroah-hartman" <gregkh@linuxfoundation.org>,
"linux kernel mailing list" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH] driver core: Add missing pm_runtime_put_noidle
Date: Tue, 18 Jan 2022 18:57:03 +0800 (GMT+08:00) [thread overview]
Message-ID: <3861fca1.2105f.17e6cd545c0.Coremail.lyz_cs@pku.edu.cn> (raw)
In-Reply-To: <CAJZ5v0heMSa82qSVrrjrv2ioz5y-18rCKThjbPBACJ6xuXQQQg@mail.gmail.com>
> -----原始邮件-----
> 发件人: "Rafael J. Wysocki" <rafael@kernel.org>
> 发送时间: 2022-01-17 22:01:54 (星期一)
> 收件人: "Yongzhi Liu" <lyz_cs@pku.edu.cn>
> 抄送: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
> 主题: Re: [PATCH] driver core: Add missing pm_runtime_put_noidle
>
> On Mon, Jan 17, 2022 at 12:08 PM Yongzhi Liu <lyz_cs@pku.edu.cn> wrote:
> >
> > pm_runtime_get_noresume() in device_shutdown increments the
> > runtime PM usage counter,
>
> This is on purpose, to prevent devices from being runtime-suspended
> after their shutdown callbacks have run.
>
> > thus a matching decrement is needed
>
> No, it is not, AFAICS.
>
> > to keep the counter balanced.
> >
> > Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
> > ---
> > drivers/base/core.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > index fd034d7..29950bd 100644
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -4523,6 +4523,8 @@ void device_shutdown(void)
> > dev->driver->shutdown(dev);
> > }
> >
> > + pm_runtime_put_noidle(dev);
> > +
> > device_unlock(dev);
> > if (parent)
> > device_unlock(parent);
> > --
> > 2.7.4
> >
Yes, thanks for your reply.
prev parent reply other threads:[~2022-01-18 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 11:07 [PATCH] driver core: Add missing pm_runtime_put_noidle Yongzhi Liu
2022-01-17 14:01 ` Rafael J. Wysocki
2022-01-18 10:57 ` 刘永志 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3861fca1.2105f.17e6cd545c0.Coremail.lyz_cs@pku.edu.cn \
--to=lyz_cs@pku.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).