linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: "jason-jh.lin" <jason-jh.lin@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: CK Hu <ck.hu@mediatek.com>, Nancy Lin <nancy.lin@mediatek.com>,
	Singo Chang <singo.chang@mediatek.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v19 10/10] soc: mediatek: remove DDP_DOMPONENT_DITHER enum
Date: Fri, 15 Apr 2022 12:32:40 +0200	[thread overview]
Message-ID: <387ede3f-20be-cb84-f343-f68c75eaf5fd@collabora.com> (raw)
In-Reply-To: <20220415083911.5186-11-jason-jh.lin@mediatek.com>

Il 15/04/22 10:39, jason-jh.lin ha scritto:
> After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0,
> mmsys header can remove the useless DDP_COMPONENT_DITHER enum.
> 
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>

Can you please fix the commit title with:
soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

that "from" is important, as you're not removing *an enum*, but *from an enum*.

After that:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Thanks!
Angelo

  parent reply	other threads:[~2022-04-15 10:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220415083911.5186-1-jason-jh.lin@mediatek.com>
     [not found] ` <20220415083911.5186-4-jason-jh.lin@mediatek.com>
2022-04-15 10:18   ` [PATCH v19 03/10] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0 AngeloGioacchino Del Regno
2022-04-18  3:52     ` Jason-JH Lin
     [not found] ` <20220415083911.5186-8-jason-jh.lin@mediatek.com>
2022-04-15 10:18   ` [PATCH v19 07/10] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195 AngeloGioacchino Del Regno
     [not found] ` <20220415083911.5186-11-jason-jh.lin@mediatek.com>
2022-04-15 10:32   ` AngeloGioacchino Del Regno [this message]
2022-04-18  3:57     ` [PATCH v19 10/10] soc: mediatek: remove DDP_DOMPONENT_DITHER enum Jason-JH Lin
     [not found] ` <20220415083911.5186-10-jason-jh.lin@mediatek.com>
2022-04-15 10:32   ` [PATCH v19 09/10] drm/mediatek: add postfix 0 to DDP_COMPONENT_DITHER for mt8195 vdosys0 AngeloGioacchino Del Regno
2022-04-18  3:54     ` Jason-JH Lin
     [not found] ` <20220415083911.5186-9-jason-jh.lin@mediatek.com>
2022-04-15 10:32   ` [PATCH v19 08/10] soc: mediatek: add DDP_DOMPONENT_DITHER0 enum " AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=387ede3f-20be-cb84-f343-f68c75eaf5fd@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason-jh.lin@mediatek.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nancy.lin@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=singo.chang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).