linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Denis Efremov <efremov@linux.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Linux-kernel <linux-kernel@vger.kernel.org>
Subject: [GIT PULL] Floppy patch for 5.15
Date: Sun, 29 Aug 2021 13:08:30 +0300	[thread overview]
Message-ID: <388418f4-2b9a-6fed-836c-a004369dc7c0@linux.com> (raw)

Hi Jens,

Sorry for the late PR this time. I'll resend it later if it's too late for
your for-5.15/drivers branch. Thanks.

The following changes since commit 461d971215dfb55bcd5f7d040b2b222592040f95:

  Merge branch 'md-next' of https://git.kernel.org/pub/scm/linux/kernel/git/song/md into for-5.15/drivers (2021-08-27 16:32:01 -0600)

are available in the Git repository at:

  https://github.com/evdenis/linux-floppy tags/floppy-for-5.15

for you to fetch changes up to c7e9d0020361f4308a70cdfd6d5335e273eb8717:

  Revert "floppy: reintroduce O_NDELAY fix" (2021-08-28 11:16:47 +0300)

Please, pull

----------------------------------------------------------------
Bring back O_NDELAY for floppy

Only one commit this time with revert of O_NDELAY removal for the floppy.
Users reported that the commit breaks userspace utils and known floppy
workflow patterns. We already reverted the same commit back in 2016
presumably for the same reason. Completely drop O_NDELAY for floppy seems
excessive to solve problems it introduces.

I started to write basic selftests for the floppy to prevent this kind of
userspace breaks in the future.

Signed-off-by: Denis Efremov <efremov@linux.com>

----------------------------------------------------------------
Denis Efremov (1):
      Revert "floppy: reintroduce O_NDELAY fix"

 drivers/block/floppy.c | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

             reply	other threads:[~2021-08-29 10:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29 10:08 Denis Efremov [this message]
2021-08-29 12:52 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=388418f4-2b9a-6fed-836c-a004369dc7c0@linux.com \
    --to=efremov@linux.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [GIT PULL] Floppy patch for 5.15' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).