From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754866AbcE3M1N (ORCPT ); Mon, 30 May 2016 08:27:13 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:45022 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbcE3M1M (ORCPT ); Mon, 30 May 2016 08:27:12 -0400 From: Markus Pargmann To: "Pranay Kr. Srivastava" Cc: nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4]nbd: fixes for nbd Date: Mon, 30 May 2016 14:27:09 +0200 Message-ID: <3898019.JRqDjBPssX@adelgunde> User-Agent: KMail/4.14.1 (Linux/4.5.0-0.bpo.2-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1464089188-6155-1-git-send-email-pranjas@gmail.com> References: <1464089188-6155-1-git-send-email-pranjas@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3929348.3rH8HJT4uq"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-SA-Exim-Connect-IP: 2001:67c:670:100:a61f:72ff:fe68:75ba X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3929348.3rH8HJT4uq Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Hi, On Tuesday 24 May 2016 14:26:24 Pranay Kr. Srivastava wrote: > This patch series fixes the following >=20 > 1) fix might_sleep warning on socket shutdown: > Fix sock_shutdown to avoid calling kernel_sock_shutdown > while holding spin_lock. >=20 > 2)fix various coding standard warnings > Make shutdown get called in a process context instead, using > system_wq. >=20 > 3) make nbd device wait for its users. > When a timeout or error occurs then nbd driver simply kills > the block device. Many filesystem(s) example ext2/ext3 don't > expect their buffer heads to disappear like that. Fix this > by making nbd device wait for its users. >=20 > 4) use device_attr macros for sysfs attribute > use DEVICE_ATTR_RO for sysfs pid attribute. Thanks, I applied patches 2 and 4. For the next version please add a "nbd: " prefix to the other patches. Best Regards, Markus =2D-=20 Pengutronix e.K. | = | Industrial Linux Solutions | http://www.pengutronix.de/= | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 = | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555= 5 | --nextPart3929348.3rH8HJT4uq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXTDGdAAoJEEpcgKtcEGQQnAEP/R82P46EjIUQ9Y6tf7S5n62z FDxJeb+usKF15VZF0gMj81oKEjqRWWB1/VtOb7mCRIrLgt5Phm5tptyUz7Iz8Wfp WfZy6FiDKbEGJ787ENPa6f8VtfQ/Qn9iXwLJlSUIQjuGmVUuEvew5WHPTMoZ9waa QUkEEHfWIQTHlPL5vSD1V3dmZieyYAw2r/HtbFYUKnEHxVazAxkCIgK4kVO6lgIx rOr+HiADm5SRth/ToVBueG1r08glbCZvCQAZJqm7NV6o+3HLrsQPPY9PCQIisBMy CgL1/13uCP7IyCKrqCb7qFc6w0VqRAdYi8HZIdaFG2VDWv0PK1w4zyZIMk62DX84 FtHkV0Oq7Nxva08LsDhja/KYpLoZ4q7kWH41FdFsqyH0xNq+Gugj7MJNmloRUcqX D6QTPHFLqpuxNok5i8jv2yUKdHlP9FxiLMEsSzB+5nbb4+Tv3pYjyf0oLVkG+VPA yxNtLgOgnpury3BXtj6X+JV9UPUhinWpMMrKGLIE86CON6RCupidTlLqVP0wsTOI BwzM37w1VMLbI8lZg3MygoRTvCE1FVQKqyQYJEa0rJBymdCyGeMYXn5XCSvXCCJj 5nmF3jpAGfT+G1iUlXTgUrc3Ja05GxXsnVZNPrsnK3hr6jDpR6UJVD7QIQTGbFsX m0OxEUcPkhLZltSJfap2 =dFjC -----END PGP SIGNATURE----- --nextPart3929348.3rH8HJT4uq--