From: Song Liu <songliubraving@fb.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Kairui Song <kasong@redhat.com>
Subject: Re: [PATCH 8/9] x86/bpf: Convert asm comments to AT&T syntax
Date: Fri, 14 Jun 2019 15:13:23 +0000 [thread overview]
Message-ID: <38F47DBB-F98F-4C12-B7D0-A363085065F3@fb.com> (raw)
In-Reply-To: <20190614074245.GS3436@hirez.programming.kicks-ass.net>
> On Jun 14, 2019, at 12:42 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Thu, Jun 13, 2019 at 06:52:24PM +0000, Song Liu wrote:
>>> On Jun 13, 2019, at 6:21 AM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
>>> @@ -403,11 +403,11 @@ static void emit_mov_imm64(u8 **pprog, u32 dst_reg,
>>> * For emitting plain u32, where sign bit must not be
>>> * propagated LLVM tends to load imm64 over mov32
>>> * directly, so save couple of bytes by just doing
>>> - * 'mov %eax, imm32' instead.
>>> + * 'mov imm32, %eax' instead.
>>> */
>>> emit_mov_imm32(&prog, false, dst_reg, imm32_lo);
>>> } else {
>>> - /* movabsq %rax, imm64 */
>>> + /* movabs imm64, %rax */
>>
>> ^^^^^ Should this be moveabsq?
>>
>>> EMIT2(add_1mod(0x48, dst_reg), add_1reg(0xB8, dst_reg));
>>> EMIT(imm32_lo, 4);
>>> EMIT(imm32_hi, 4);
>
> Song, can you please trim replies; I only found what you said because of
> Josh's reply.
Sorry for the problem. I will trim in the future.
Song
next prev parent reply other threads:[~2019-06-14 15:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 13:20 [PATCH 0/9] x86/bpf: unwinder fixes Josh Poimboeuf
2019-06-13 13:20 ` [PATCH 1/9] perf/x86: Always store regs->ip in perf_callchain_kernel() Josh Poimboeuf
2019-06-13 13:20 ` [PATCH 2/9] objtool: Fix ORC unwinding in non-JIT BPF generated code Josh Poimboeuf
2019-06-13 20:57 ` Alexei Starovoitov
2019-06-14 1:20 ` Josh Poimboeuf
2019-06-14 1:37 ` Alexei Starovoitov
2019-06-14 1:51 ` Josh Poimboeuf
2019-06-14 7:08 ` Peter Zijlstra
2019-06-14 7:35 ` Alexei Starovoitov
2019-06-14 8:11 ` Peter Zijlstra
2019-06-14 15:13 ` Alexei Starovoitov
2019-06-14 16:11 ` Josh Poimboeuf
2019-06-13 13:21 ` [PATCH 3/9] x86/bpf: Move epilogue generation to a dedicated function Josh Poimboeuf
2019-06-13 18:57 ` Song Liu
2019-06-13 19:12 ` Josh Poimboeuf
2019-06-13 13:21 ` [PATCH 4/9] x86/bpf: Simplify prologue generation Josh Poimboeuf
2019-06-13 13:21 ` [PATCH 5/9] x86/bpf: Support SIB byte generation Josh Poimboeuf
2019-06-13 13:21 ` [PATCH 6/9] x86/bpf: Fix JIT frame pointer usage Josh Poimboeuf
2019-06-13 21:58 ` Alexei Starovoitov
2019-06-14 1:22 ` Josh Poimboeuf
2019-06-14 1:39 ` Alexei Starovoitov
2019-06-14 1:52 ` Josh Poimboeuf
2019-06-14 10:50 ` David Laight
2019-06-14 13:44 ` Josh Poimboeuf
2019-06-14 13:58 ` David Laight
2019-06-14 17:07 ` Josh Poimboeuf
2019-06-17 15:07 ` David Laight
2019-06-13 13:21 ` [PATCH 7/9] x86/unwind/orc: Fall back to using frame pointers for generated code Josh Poimboeuf
2019-06-13 22:00 ` Alexei Starovoitov
2019-06-14 1:30 ` Josh Poimboeuf
2019-06-14 1:42 ` Alexei Starovoitov
2019-06-14 1:58 ` Josh Poimboeuf
2019-06-14 2:28 ` Josh Poimboeuf
2019-06-14 4:50 ` Josh Poimboeuf
2019-06-14 6:00 ` Alexei Starovoitov
2019-06-14 7:41 ` Peter Zijlstra
2019-06-14 13:31 ` Josh Poimboeuf
2019-06-14 15:29 ` Alexei Starovoitov
2019-06-14 13:34 ` Josh Poimboeuf
2019-06-14 15:31 ` Alexei Starovoitov
2019-06-14 15:56 ` Josh Poimboeuf
2019-06-13 13:21 ` [PATCH 8/9] x86/bpf: Convert asm comments to AT&T syntax Josh Poimboeuf
2019-06-13 18:52 ` Song Liu
2019-06-13 19:11 ` Josh Poimboeuf
2019-06-14 7:42 ` Peter Zijlstra
2019-06-14 15:13 ` Song Liu [this message]
2019-06-13 13:21 ` [PATCH 9/9] x86/bpf: Convert MOV function/macro argument ordering " Josh Poimboeuf
2019-06-13 19:00 ` [PATCH 0/9] x86/bpf: unwinder fixes Song Liu
2019-06-13 20:41 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38F47DBB-F98F-4C12-B7D0-A363085065F3@fb.com \
--to=songliubraving@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jpoimboe@redhat.com \
--cc=kasong@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).