From: Vlastimil Babka <vbabka@suse.cz>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] mm/page_alloc: Make deferred page init free pages in MAX_ORDER blocks
Date: Tue, 21 Mar 2023 12:41:05 +0100 [thread overview]
Message-ID: <38b82ca1-29c2-4ce5-b7d6-bf1b7dcc365b@suse.cz> (raw)
In-Reply-To: <20230321002415.20843-1-kirill.shutemov@linux.intel.com>
On 3/21/23 01:24, Kirill A. Shutemov wrote:
> Normal page init path frees pages during the boot in MAX_ORDER chunks,
> but deferred page init path does it in pageblock blocks.
>
> Change deferred page init path to work in MAX_ORDER blocks.
>
> For cases when MAX_ORDER is larger than pageblock, set migrate type to
> MIGRATE_MOVABLE for all pageblocks covered by the page.
Looks like the problems with migratetype were why commit e780149bcd4b ("mm:
fix set pageblock migratetype in deferred struct page init") switched it
from MAX_ORDER to pageblock_order. This should work better.
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
But I think you'll have to rebase on mm-unstable that moved some of the code
to mm_init.c
next prev parent reply other threads:[~2023-03-21 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 0:24 [PATCHv2] mm/page_alloc: Make deferred page init free pages in MAX_ORDER blocks Kirill A. Shutemov
2023-03-21 11:41 ` Vlastimil Babka [this message]
2023-03-21 13:48 ` David Hildenbrand
2023-03-21 16:53 ` Mel Gorman
2023-03-22 6:23 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38b82ca1-29c2-4ce5-b7d6-bf1b7dcc365b@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).