From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC7FC433E1 for ; Tue, 23 Mar 2021 08:16:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5980D619BA for ; Tue, 23 Mar 2021 08:16:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229865AbhCWIQ3 (ORCPT ); Tue, 23 Mar 2021 04:16:29 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:53656 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbhCWIPy (ORCPT ); Tue, 23 Mar 2021 04:15:54 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12N8FlD4076257; Tue, 23 Mar 2021 03:15:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1616487347; bh=oKHA/+wDpJIi+yfZPc9GKqDKP7a1DyUbhBnTJOCDVko=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=vxOwqmLMq39fS9KhIcYt2/IPVsg7cFev42GXzoW6w5Q/V8mTkb0NEYcyJEMs6j1+/ ftxRuAoE0TvOsyqxTwuNnOteDzSen+HzmyMCmj9Xs4WnXRRMuK+BS+DeKowre7Onoi 3/48FydtLOgorMsIhF9h5Eua0GSyra0ovTjMHTbo= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12N8FlCb076636 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 23 Mar 2021 03:15:47 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 23 Mar 2021 03:15:41 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Tue, 23 Mar 2021 03:15:41 -0500 Received: from [172.24.145.148] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12N8FbnM097646; Tue, 23 Mar 2021 03:15:38 -0500 Subject: Re: [PATCH v7 3/3] arm64: dts: ti: k3-j7200: Add support for higher speed modes and update delay select values for MMCSD subsystems To: Kishon Vijay Abraham I , Nishanth Menon CC: Vignesh Raghavendra , Lokesh Vutla , Tero Kristo , Rob Herring , , , References: <20210322131206.24887-1-a-govindraju@ti.com> <20210322131206.24887-4-a-govindraju@ti.com> <20210322153547.d5hkqydpe372rpwg@manicure> <599d06e5-2b8f-011f-cf8d-3ccf34ee37b1@ti.com> From: Aswath Govindraju Message-ID: <38c3e0aa-263d-677d-6ab0-b1d089d4699e@ti.com> Date: Tue, 23 Mar 2021 13:45:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <599d06e5-2b8f-011f-cf8d-3ccf34ee37b1@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon, On 23/03/21 11:59 am, Kishon Vijay Abraham I wrote: > Hi Aswath, > > On 23/03/21 10:54 am, Aswath Govindraju wrote: >> Hi Nishanth, >> >> On 22/03/21 9:05 pm, Nishanth Menon wrote: >>> On 18:42-20210322, Aswath Govindraju wrote: >>>> The following speed modes are now supported in J7200 SoC, >>>> - HS200 and HS400 modes at 1.8 V card voltage, in MMCSD0 subsystem [1]. >>>> - UHS-I speed modes in MMCSD1 subsystem [1]. >>>> >>>> Add support for UHS-I modes by adding voltage regulator device tree nodes >>>> and corresponding pinmux details, to power cycle and voltage switch cards. >>>> Set respective tags in sdhci0 and remove no-1-8-v tag from sdhci1 >>>> device tree nodes. >>>> >>>> Also update the delay values for various speed modes supported, based on >>>> the revised january 2021 J7200 datasheet[2]. >>>> >>>> [1] - section 12.3.6.1.1 MMCSD Features, in >>>> https://www.ti.com/lit/ug/spruiu1a/spruiu1a.pdf, >>>> (SPRUIU1A – JULY 2020 – REVISED JANUARY 2021) >>>> >>>> [2] - https://www.ti.com/lit/ds/symlink/dra821u.pdf, >>>> (SPRSP57B – APRIL 2020 – REVISED JANUARY 2021) >>>> >>>> Signed-off-by: Aswath Govindraju >>>> --- >>>> .../dts/ti/k3-j7200-common-proc-board.dts | 42 +++++++++++++++++++ >>>> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 14 ++++++- >>>> 2 files changed, 54 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >>>> index b493f939b09a..de8c06bdc825 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >>>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts >>>> @@ -16,6 +16,29 @@ >>>> stdout-path = "serial2:115200n8"; >>>> bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000"; >>>> }; >>>> + >>>> + vdd_mmc1: fixedregulator-sd { >>>> + compatible = "regulator-fixed"; >>>> + regulator-name = "vdd_mmc1"; >>>> + regulator-min-microvolt = <3300000>; >>>> + regulator-max-microvolt = <3300000>; >>>> + regulator-boot-on; >>>> + enable-active-high; >>>> + gpios = <&exp2 2 GPIO_ACTIVE_HIGH>; >>> >>> is that gpio ? >> >> Yes, that is correct. I'll correct it in the respin >> >>> I'd encourage to use vin-supply as well. >> >> Will add this in respin. >> >>> >>>> + }; >>>> + >>>> + vdd_sd_dv: gpio-regulator-vdd-sd-dv { >>> What does this drive? TLV71033 ? >> >> Yes, this node models the TLV71033 voltage regulator that switches the >> MMC IO signal voltage level between 3.3V and 1.8V. > > Nope. Unlike J721e SOM which uses TLV71033 for switching voltage, J7200 > SOM directly uses GPIO input to PMIC to control the output voltage. So > this should model the gpio input to PMIC. > This was the case with older SoMs and on newer ones load switches are being used[1]. [1] - https://www.ti.com/lit/zip/sprr424, PROC105E6(001)_SCH.pdf, page 24 Thanks, Aswath