From: Mukesh Ojha <mojha@codeaurora.org>
To: Yue Haibing <yuehaibing@huawei.com>,
aisheng.dong@nxp.com, festevam@gmail.com, shawnguo@kernel.org,
stefan@agner.ch, kernel@pengutronix.de, linus.walleij@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static
Date: Thu, 21 Mar 2019 01:28:28 +0530 [thread overview]
Message-ID: <38d8265b-52b9-f7fd-d665-46b66848118a@codeaurora.org> (raw)
In-Reply-To: <20190320141425.20920-1-yuehaibing@huawei.com>
On 3/20/2019 7:44 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/pinctrl/freescale/pinctrl-scu.c:38:19: warning:
> symbol 'pinctrl_ipc_handle' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pinctrl/freescale/pinctrl-scu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-scu.c b/drivers/pinctrl/freescale/pinctrl-scu.c
> index 83e69c0..73bf1d9 100644
> --- a/drivers/pinctrl/freescale/pinctrl-scu.c
> +++ b/drivers/pinctrl/freescale/pinctrl-scu.c
> @@ -35,7 +35,7 @@ struct imx_sc_msg_resp_pad_get {
> u32 val;
> } __packed;
>
> -struct imx_sc_ipc *pinctrl_ipc_handle;
> +static struct imx_sc_ipc *pinctrl_ipc_handle;
>
> int imx_pinctrl_sc_ipc_init(struct platform_device *pdev)
> {
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
next prev parent reply other threads:[~2019-03-20 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 14:14 [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static Yue Haibing
2019-03-20 19:58 ` Mukesh Ojha [this message]
2019-04-04 5:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38d8265b-52b9-f7fd-d665-46b66848118a@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=aisheng.dong@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).