From: Paolo Bonzini <pbonzini@redhat.com>
To: Vineeth Pillai <viremana@linux.microsoft.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH] KVM: SVM: delay svm_vcpu_init_msrpm after svm->vmcb is initialized
Date: Thu, 29 Jul 2021 18:30:49 +0200 [thread overview]
Message-ID: <38eb919c-2da1-648e-10a4-a76205fd5e96@redhat.com> (raw)
In-Reply-To: <1d82501c-05fd-deff-9652-790cde052644@linux.microsoft.com>
On 28/07/21 22:18, Vineeth Pillai wrote:
>
> On 7/27/2021 11:23 AM, Vitaly Kuznetsov wrote:
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>>> Right now, svm_hv_vmcb_dirty_nested_enlightenments has an incorrect
>>> dereference of vmcb->control.reserved_sw before the vmcb is checked
>>> for being non-NULL. The compiler is usually sinking the dereference
>>> after the check; instead of doing this ourselves in the source,
>>> ensure that svm_hv_vmcb_dirty_nested_enlightenments is only called
>>> with a non-NULL VMCB.
>>>
>>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>>> Cc: Vineeth Pillai <viremana@linux.microsoft.com>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> [Untested for now due to issues with my AMD machine. - Paolo]
> Finally got hold of an AMD machine and tested nested virt: windows on
> linux on
> windows with the patches applied. Did basic boot and minimal verification.
>
> Tested-by: Vineeth Pillai <viremana@linux.microsoft.com>
Thanks! In the meanwhile I had fixed my machine too. :)
Paolo
next prev parent reply other threads:[~2021-07-29 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 16:58 [PATCH] KVM: SVM: delay svm_vcpu_init_msrpm after svm->vmcb is initialized Paolo Bonzini
2021-07-27 0:41 ` Vineeth Pillai
2021-07-27 15:23 ` Vitaly Kuznetsov
2021-07-28 20:18 ` Vineeth Pillai
2021-07-29 16:30 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-26 16:49 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38eb919c-2da1-648e-10a4-a76205fd5e96@redhat.com \
--to=pbonzini@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viremana@linux.microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).