linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Xishi Qiu <qiuxishi@huawei.com>
Cc: "Izumi, Taku" <izumi.taku@jp.fujitsu.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"mel@csn.ul.ie" <mel@csn.ul.ie>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	"matt@codeblueprint.co.uk" <matt@codeblueprint.co.uk>
Subject: RE: [PATCH v3 2/2] mm: Introduce kernelcore=mirror option
Date: Thu, 17 Dec 2015 18:43:20 +0000	[thread overview]
Message-ID: <3908561D78D1C84285E8C5FCA982C28F39F882E8@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <567241BE.5030806@jp.fujitsu.com>

>>> As Tony requested, we may need a knob to stop a fallback in "movable->normal", later.
>>>
>> 
>> If the mirrored memory is small and the other is large,
>> I think we can both enable "non-mirrored -> normal" and "normal -> non-mirrored".
>
> Size of mirrored memory can be configured by software(EFI var).
> So, having both is just overkill and normal->non-mirroed fallback is meaningless considering
> what the feature want to guarantee.

In the original removable usage we wanted to guarantee that Linux did not allocate any
kernel objects in removable memory - because that would prevent later removal of that
memory.

Mirror case is the same - we don't want to allocate kernel structures in non-mirrored memory
because an uncorrectable error in one of them would crash the system.

But I think some users might like some flexibility here.  If the system doesn't have enough
memory for the kernel (non-movable or mirrored), then it seems odd to end up crashing
the system at the point of memory exhaustion (a likely result ... the kernel can try to reclaim
some pages from SLAB, but that might only return a few pages, if the shortage continues
the system will perform poorly and eventually fail).

The whole point of removable memory or mirrored memory is to provide better availability.

I'd vote for a mode where running out of memory for kernel results in a

   warn_on_once("Ran out of mirrored/non-removable memory for kernel - now allocating from all zones\n")

because I think most people would like the system to stay up rather than worry about some future problem that may never happen.

-Tony




  reply	other threads:[~2015-12-17 18:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09  3:18 [PATCH v3 0/2] mm: Introduce kernelcore=mirror option Taku Izumi
2015-12-09  3:19 ` [PATCH v3 1/2] mm: Calculate zone_start_pfn at zone_spanned_pages_in_node() Taku Izumi
2015-12-09  3:19 ` [PATCH v3 2/2] mm: Introduce kernelcore=mirror option Taku Izumi
2015-12-09  3:28   ` Xishi Qiu
2015-12-09 21:59     ` Luck, Tony
2015-12-10  1:14       ` Xishi Qiu
2015-12-10  5:37         ` Izumi, Taku
2015-12-10  6:13           ` Xishi Qiu
2015-12-11  5:53             ` Izumi, Taku
2015-12-11  9:44               ` Xishi Qiu
2015-12-17  1:38                 ` Izumi, Taku
2015-12-17  2:47                   ` Xishi Qiu
2015-12-17  2:53                     ` Kamezawa Hiroyuki
2015-12-17  4:48                       ` Xishi Qiu
2015-12-17  5:01                         ` Kamezawa Hiroyuki
2015-12-17 18:43                           ` Luck, Tony [this message]
2015-12-18  2:12                             ` Kamezawa Hiroyuki
2015-12-18  6:59                               ` Luck, Tony
2015-12-28 22:21   ` Andrew Morton
2015-12-28 22:32   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3908561D78D1C84285E8C5FCA982C28F39F882E8@ORSMSX114.amr.corp.intel.com \
    --to=tony.luck@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mel@csn.ul.ie \
    --cc=qiuxishi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).