From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753494AbcFBQQa (ORCPT ); Thu, 2 Jun 2016 12:16:30 -0400 Received: from mga09.intel.com ([134.134.136.24]:40022 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752251AbcFBQQ2 convert rfc822-to-8bit (ORCPT ); Thu, 2 Jun 2016 12:16:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,407,1459839600"; d="scan'208";a="979588000" From: "Luck, Tony" To: Dave Hansen , "linux-kernel@vger.kernel.org" CC: "x86@kernel.org" , "dave.hansen@linux.intel.com" , "mchehab@osg.samsung.com" , "dougthompson@xmission.com" , "bp@alien8.de" , "linux-edac@vger.kernel.org" Subject: RE: [PATCH 12/20] x86, edac: use Intel family name macros for edac driver Thread-Topic: [PATCH 12/20] x86, edac: use Intel family name macros for edac driver Thread-Index: AQHRvGNsyFRrLg6aMEOZMCtaioVicp/WWTXQ Date: Thu, 2 Jun 2016 16:16:24 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F3A100934@ORSMSX113.amr.corp.intel.com> References: <20160602001157.D8BE59D7@viggo.jf.intel.com> <20160602001214.A5E42252@viggo.jf.intel.com> In-Reply-To: <20160602001214.A5E42252@viggo.jf.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Another straightforward replacement of magic numbers. It would be if I hadn't forgotten that INTEL_FAM6_MODEL_BROADWELL_XEON_D had a separate model number from the other Broadwell Xeons when I switched the driver from PCI device lookup to cpu model number. This needs to add an entry for BDX-DE (use the same table initializer). Probably as a separate patch before/after this. -Tony [The name INTEL_FAM6_MODEL_BROADWELL_XEON_D is so long it will spoil the line-up of this code ... +1 vote on Boris' suggestion to drop the "MODEL_" bit from all these names]