From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161602AbcFBR1S (ORCPT ); Thu, 2 Jun 2016 13:27:18 -0400 Received: from mga11.intel.com ([192.55.52.93]:5439 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161410AbcFBR1O convert rfc822-to-8bit (ORCPT ); Thu, 2 Jun 2016 13:27:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,407,1459839600"; d="scan'208";a="967643958" From: "Luck, Tony" To: Dave Hansen , "linux-kernel@vger.kernel.org" CC: "x86@kernel.org" , "dave.hansen@linux.intel.com" , "mchehab@osg.samsung.com" , "dougthompson@xmission.com" , "bp@alien8.de" , "linux-edac@vger.kernel.org" Subject: RE: [PATCH 12/20] x86, edac: use Intel family name macros for edac driver Thread-Topic: [PATCH 12/20] x86, edac: use Intel family name macros for edac driver Thread-Index: AQHRvGNsyFRrLg6aMEOZMCtaioVicp/WWTXQgAAUwpA= Date: Thu, 2 Jun 2016 17:27:13 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F3A101C74@ORSMSX113.amr.corp.intel.com> References: <20160602001157.D8BE59D7@viggo.jf.intel.com> <20160602001214.A5E42252@viggo.jf.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This needs to add an entry for BDX-DE (use the same table initializer). Probably as > a separate patch before/after this. Oops ... a bit worse than that. I assumed that index into the array matches the enum ... (with a comment!) ... having two entries for the same "type" would break that. I'll have to add a type field to something. If your patch is on a fast-track, then go ahead with it: Acked-by: Tony Luck I'll work on fixing the other mess independently -Tony