From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752307AbdHPPWs convert rfc822-to-8bit (ORCPT ); Wed, 16 Aug 2017 11:22:48 -0400 Received: from mga09.intel.com ([134.134.136.24]:60661 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620AbdHPPWp (ORCPT ); Wed, 16 Aug 2017 11:22:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,383,1498546800"; d="scan'208";a="119634565" From: "Luck, Tony" To: Punit Agrawal CC: "Rafael J. Wysocki" , Len Brown , Boris Petkov , Tyler Baicar , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ACPI/APEI: Add BERT data driver Thread-Topic: [PATCH] ACPI/APEI: Add BERT data driver Thread-Index: AQHTFpGNsXQ/Ipok40Ku7qLCw7+Xh6KHFxmA Date: Wed, 16 Aug 2017 15:22:44 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F61340302@ORSMSX114.amr.corp.intel.com> References: <20170814165613.25561-1-tony.luck@intel.com> <87k225p1v5.fsf@e105922-lin.cambridge.arm.com> <20170815211556.nnnnbtlvorgc3ijh@intel.com> <87a82zpsd7.fsf@e105922-lin.cambridge.arm.com> In-Reply-To: <87a82zpsd7.fsf@e105922-lin.cambridge.arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > One thing I missed commenting on in the previous version - > > Have you thought of exposing the error records via /sys/firmware/acpi? > The tables are already exposed there and as BERT is part of ACPI > logically that's a better fit compared to a misc device. That was my first thought :-) But I got stuck on how to name things. The BERT entry appears in /sys/firmware/acpi/tables/ ... but the code doesn't know anything special about "BERT", it just iterates over all the tables and makes them all appear. I thought about making it /sys/firmware/acpi/tables/BERT.data, but that seemed very ugly (this file isn't a "table", so why does it appear in the "tables" directory? So maybe /sys/firmware/acpi/table-data/BERT? Now the driver has to make another directory. Thoughts? -Tony