From: "Luck, Tony" <tony.luck@intel.com>
To: "Hansen, Dave" <dave.hansen@intel.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, H Peter Anvin <hpa@zytor.com>
Cc: "Raj, Ashok" <ashok.raj@intel.com>,
Alan Cox <alan@linux.intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: RE: [PATCH v2 3/4] x86/split_lock: Handle #AC exception for split lock
Date: Fri, 29 Jun 2018 16:33:54 +0000 [thread overview]
Message-ID: <3908561D78D1C84285E8C5FCA982C28F7D348C9A@ORSMSX110.amr.corp.intel.com> (raw)
In-Reply-To: <f528ef21-0e6f-3c76-5fac-bd88279facc0@intel.com>
>> + WARN_ONCE(1, "A split lock issue is detected. Please FIX it\n");
>
> But, warning here is also not super useful. Shouldn't we be dumping out
> the info in 'regs' instead of the current context? We don't care about
> the state in the #AC handler, we care about 'regs'.
Maybe:
WARN_ONCE(1, "split lock detected at %pF\n", regs[EIP]);
-Tony
next prev parent reply other threads:[~2018-06-29 16:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 14:33 [PATCH v2 0/4] x86/split_lock: Enable #AC exception for split locked accesses Fenghua Yu
2018-06-29 14:33 ` [PATCH v2 1/4] x86/split_lock: Enumerate #AC exception for split locked access feature Fenghua Yu
2018-06-29 14:56 ` Dave Hansen
2018-06-29 16:23 ` Thomas Gleixner
2018-06-29 16:32 ` Dave Hansen
2018-07-04 20:07 ` Eduardo Habkost
2018-07-10 18:45 ` Fenghua Yu
2018-07-10 18:54 ` Dave Hansen
2018-07-10 19:47 ` Thomas Gleixner
2018-07-11 19:59 ` Dave Hansen
2018-07-12 20:00 ` Thomas Gleixner
2018-06-29 14:33 ` [PATCH v2 2/4] x86/split_lock: Align x86_capability to unsigned long to avoid split locked access Fenghua Yu
2018-06-29 16:04 ` Dave Hansen
2018-06-29 16:35 ` Thomas Gleixner
2018-06-29 19:03 ` Fenghua Yu
2018-06-29 20:08 ` Thomas Gleixner
2018-06-29 20:38 ` Fenghua Yu
2018-06-29 20:48 ` Dave Hansen
2018-06-29 21:10 ` Fenghua Yu
2018-06-29 21:44 ` Thomas Gleixner
2018-06-30 0:00 ` Fenghua Yu
2018-06-30 0:14 ` Fenghua Yu
2018-06-30 6:23 ` Thomas Gleixner
2018-07-02 12:18 ` Peter Zijlstra
2018-07-02 14:11 ` Fenghua Yu
2018-06-29 14:33 ` [PATCH v2 3/4] x86/split_lock: Handle #AC exception for split lock Fenghua Yu
2018-06-29 16:29 ` Dave Hansen
2018-06-29 16:33 ` Luck, Tony [this message]
2018-06-29 17:16 ` Fenghua Yu
2018-06-29 17:29 ` Dave Hansen
2018-06-29 17:39 ` Fenghua Yu
2018-06-29 17:47 ` Dave Hansen
2018-06-29 14:33 ` [PATCH v2 4/4] x86/split_lock: Disable #AC for split locked accesses Fenghua Yu
2018-06-29 16:31 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3908561D78D1C84285E8C5FCA982C28F7D348C9A@ORSMSX110.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=alan@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=dave.hansen@intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ravi.v.shankar@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).