From: "Luck, Tony" <tony.luck@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Borislav Petkov <bp@alien8.de>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Lee, Chun-Yi" <joeyli.kernel@gmail.com>
Subject: RE: sb_edac.c lacks PCI domain support?
Date: Wed, 8 Aug 2018 20:18:03 +0000 [thread overview]
Message-ID: <3908561D78D1C84285E8C5FCA982C28F7D3A370D@ORSMSX110.amr.corp.intel.com> (raw)
In-Reply-To: <20180808200747.GA219159@bhelgaas-glaptop.roam.corp.google.com>
> I think sb_edac.c (and probably other EDAC stuff) lacks PCI domain
> support
There's a patch queued to fix this.
https://marc.info/?l=linux-edac&m=153256485215534&w=2
> It looks like 88ae80aa609c ("EDAC, skx_edac: Handle systems with
> segmented PCI busses") fixes a similar problem; maybe that should
> be applied elsewhere in EDAC as well?
>
> Why doesn't EDAC use the standard pci_register_driver() interface?
> That would avoid issues like this. It would also avoid the potential
> conflict of another driver operating on the device at the same time.
EDAC drivers get information to translate system physical addresses
to DIMM addresses from a whole bundle of different PCIe devices config
space. Connections between different parts of the translation algorithm
depend on finding the devices that belong to the same memory controller
by matching up bus numbers (actually <segment,busnumber> tuples as
we are now finding).
Can pci_register_driver() cope with this odd usage?
-Tony
next prev parent reply other threads:[~2018-08-08 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 20:07 sb_edac.c lacks PCI domain support? Bjorn Helgaas
2018-08-08 20:18 ` Luck, Tony [this message]
2018-08-14 13:58 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3908561D78D1C84285E8C5FCA982C28F7D3A370D@ORSMSX110.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=helgaas@kernel.org \
--cc=joeyli.kernel@gmail.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).