linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	"David S . Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/3] l3mdev icmp error route lookup fixes
Date: Mon, 21 Sep 2020 12:36:37 -0600	[thread overview]
Message-ID: <390b230b-629b-7f96-e7c9-b28f8b592102@gmail.com> (raw)
In-Reply-To: <20200918181801.2571-1-mathieu.desnoyers@efficios.com>

On 9/18/20 12:17 PM, Mathieu Desnoyers wrote:
> Hi,
> 
> Here is an updated series of fixes for ipv4 and ipv6 which which ensure
> the route lookup is performed on the right routing table in VRF
> configurations when sending TTL expired icmp errors (useful for
> traceroute).
> 
> It includes tests for both ipv4 and ipv6.
> 
> These fixes address specifically address the code paths involved in
> sending TTL expired icmp errors. As detailed in the individual commit
> messages, those fixes do not address similar issues related to network
> namespaces and unreachable / fragmentation needed messages, which appear
> to use different code paths.
> 

New selftests are failing:
TEST: Ping received ICMP frag needed                       [FAIL]

Both IPv4 and IPv6 versions are failing.

  parent reply	other threads:[~2020-09-21 18:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 18:17 [RFC PATCH v2 0/3] l3mdev icmp error route lookup fixes Mathieu Desnoyers
2020-09-18 18:17 ` [RFC PATCH v2 1/3] ipv4/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2) Mathieu Desnoyers
2020-09-18 18:18 ` [RFC PATCH v2 2/3] ipv6/icmp: " Mathieu Desnoyers
2020-09-18 18:18 ` [RFC PATCH v2 3/3] selftests: Add VRF icmp error route lookup test Mathieu Desnoyers
2020-09-21 18:36 ` David Ahern [this message]
2020-09-21 18:44   ` [RFC PATCH v2 0/3] l3mdev icmp error route lookup fixes Mathieu Desnoyers
2020-09-21 19:11     ` David Ahern
2020-09-21 19:33       ` Mathieu Desnoyers
2020-09-22 13:52         ` Michael Jeanson
2020-09-23  1:59           ` David Ahern
2020-09-23 16:04             ` Michael Jeanson
2020-09-23 17:03               ` Michael Jeanson
2020-09-23 18:46                 ` David Ahern
2020-09-23 19:12                   ` Michael Jeanson
2020-09-23 20:04                     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=390b230b-629b-7f96-e7c9-b28f8b592102@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).