From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934730AbcIFPTE (ORCPT ); Tue, 6 Sep 2016 11:19:04 -0400 Received: from mail-ve1eur01on0100.outbound.protection.outlook.com ([104.47.1.100]:40555 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932180AbcIFPS7 (ORCPT ); Tue, 6 Sep 2016 11:18:59 -0400 X-Greylist: delayed 28846 seconds by postgrey-1.27 at vger.kernel.org; Tue, 06 Sep 2016 11:18:58 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; Subject: Re: [RFC PATCH] pinctrl: Add SX150X GPIO Extender Pinctrl Driver To: Neil Armstrong , Linus Walleij , Wei Chen , Roland Stigge , Vladimir Zapolskiy References: <1472130692-14404-1-git-send-email-narmstrong@baylibre.com> <85f4ae6f-2563-967c-1e75-28a864405f53@axentia.se> <44e8d692-832f-fbbf-2930-0cd7c140a754@baylibre.com> CC: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <3922b85b-1072-6770-c8d7-58a68ecc290e@axentia.se> Date: Tue, 6 Sep 2016 12:43:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <44e8d692-832f-fbbf-2930-0cd7c140a754@baylibre.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: DB3PR01CA0048.eurprd01.prod.exchangelabs.com (10.242.133.151) To DB6PR0201MB2312.eurprd02.prod.outlook.com (10.169.222.151) X-MS-Office365-Filtering-Correlation-Id: 798ecc7c-2fa0-40d6-f604-08d3d642a686 X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;2:f3s8+gG65d9MBBOxGZWYXMwvWSeJKEBodIcsr4fhM9NUP1KWyeNv4qmLhdCo1keMQoRppOf3Sx+sD44QIOOMjvtkAy0kSbJxyFhagJrYLKqe8ybEfpOqOD6OXNg/NZgI/q39FOAVwSPa2Ipyxt/9qkBzZ4xHTML3F3S9H39O1bixGd4yFF4FLo9By+NlPldd;3:WTcZ6m77AqB4236v7KnTLWpUZh8SdlnktbIVRu6R4vRTjdGmJHYPFdGiRffiEBEe2zfElBz62yb6Bz1RNgT1QSyYGcFxkMvdau0PiW6fQPdxx7yTj/ddKU8JwIYoCvv+ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0201MB2312; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;25:d9BbT63U1kj4ieKQdos+MaC05GuwNzOUPp0crdCAoWpGdhWPksjjm445GMY0UBAO3XnDanT137k+VkhleTB6VqyAdzz6B+6l6PIiMNH/rsDHW/9Brfq1hL3oONfBV40tkiuficNSh+CVS8RX1TLI2GGghrnJ8OVBYAwZgavF715h9UIgd38gAdzFwN7p8ypo14skxdxC4lkdNxs4QtZirIPPgO4CH4GIC9CK9+vdtNS7q6VQQGn1ZX426LwQgD4p82/oKc8R+SVDxYbIMuJYeCod/ukpddhjoP+odJM+aZh9pQnrDvCGw/fWx4qLy7TykdvmhZotPfzri9JISZ5hzp5bySWxwSV6tudgt0xLwfbHgYelp6bGQ2hJOROGP7UVrnDSjGbF5vFM3qpVhmeRGWfm54rAVDWIBeVGNK0DsbBiY7TBatKRHgb1fneGFsKP87bjX1tmb/Xpn9lv9yZuDKo3r+QrO54cNsQuoQuAEot4wCy7LtAyAYLIOtDZeNo3texYGb1RvWqdji7942Pl4bLP970AQiozkQZa7L83S8U7lkVdT6sQsQcsDLH1u9DrRivJcDJqOKc0J21Jpf/LUgDfx7cZj4MgAqYiN5V93r0XQlzoVuq4Z1hccNam7nw2kVOwpFGYa7F4febdeJkiji3rYNfxMnv3ZJwiO2V2l3FRv7anJQquD5PBYKcFvQW98BfRBJGbVzmuvZqwiaTXduOhP9AiVDCdMxngXn6OvEDtKM+2UnA2bjxC2tW7f6KrvMC31iVRZxUP3Ttduzjo0qCsDSf0sNwrZ9E3PngpNcTff2J8mpGLobXsD6Mi/USV X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;31:L1/ZpWqzuzCECHTiUCNewhyFlGVvY1c9kQ5T50USuEIIBNlUWecX8+ZYumerJReV4pBpe/8BVQNKirCvtZiLnUHETPPr/1SYjcgiYZlj+mx4qQTZVvnxax8s+8e46vSWDQY2CcGMQoYpDlr8gshaWsVnaUwoauuKUjWcbsS2SsVDXUogEf1zc47XR6Lbcz9/rbW/s62W3EJxvdLLTTgDN+hNnbeIIyM1IqSvrNiXPNI=;4:H7xEu0PmUwQk0EK1pkx04IQRWfB35FwPy8nXTW37CLTEst5P0ytfz9dk/W6BmlBwERF0G824NLNf2Zpipu241Ji7l81zc/YiD9iHOUXz9qDxE5XMDMCnj2pcBEEWZrKsaK8p1vg2VnmeK92SYIpYVou15K54qkDOrsc3WuOK/KeGmlD6eAR4JvlCgFRHZs8TgtuFmuC4O6QfOXGxyVSfyCV33LQbWXE8xngpAm+BgDv1dA5rHJ2n2R0wIw/vj3E7v7qzstfHejfC9osg7HuqlyKBE/wg8nxsFOA1RbYCIoNr/U9TOhpoBarwM5jX0e2oadhSEVNEP8jV2iUwDP+8wcucJqHdRF1vrRpnz0AgLKOcZm/gN7Ba9Bu/c9ds069KZSKyxWGAQzW3KSNul0xfcDSN2IludMqvXZC3M4pfDs4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6043046)(6042046);SRVR:DB6PR0201MB2312;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0201MB2312; X-Forefront-PRVS: 0057EE387C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(189002)(24454002)(377454003)(377424004)(199003)(117156001)(4326007)(54356999)(230700001)(31696002)(64126003)(92566002)(23676002)(3846002)(77096005)(86362001)(33646002)(586003)(31686004)(36756003)(50466002)(2950100001)(65806001)(19580395003)(65956001)(74482002)(66066001)(2906002)(93886004)(83506001)(105586002)(5660300001)(106356001)(5001770100001)(42186005)(6116002)(7846002)(97736004)(81156014)(81166006)(101416001)(8676002)(189998001)(7736002)(47776003)(4001350100001)(305945005)(68736007)(65826007)(76176999)(5890100001)(50986999)(15975445007)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0201MB2312;H:[192.168.0.125];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjAyMDFNQjIzMTI7MjM6WVRxM3VqZUVmRTlGRlpUR0ltNnpvam9v?= =?utf-8?B?T0tuNU9OMHU0Q2VoNWVsTDVZdWlQMUptdnhoZ3BhcDlJOVRxWmFIVUJrYVdv?= =?utf-8?B?dmVFcjRYQVk2SEZ0R0JDNXRrNXBlSnhxL0dlRU1iQm1NU0l2QjBIK0grSDIr?= =?utf-8?B?VW8xOFRucDY5NmUzZWpsOFBRNG55RkhhcTUrZ0dMWE9GNGg2cS9PUFV1cGw5?= =?utf-8?B?M0VoM01SR21FZXQrdHZ1cENDb1VEa0RjajRoM3JFSVBQaEtmbGoxcG00bVZt?= =?utf-8?B?YzhXMXd0bFZNMjF5YkNCOFVOWGJTSHpYQ3FoU0tlR0NuOC83ZHRxK2hMZjVx?= =?utf-8?B?ZW9QMkM4MlhhYStaS1U4bkUvZFJTVjlrYytYaExHdGNrRDc5anhKa3huZkRo?= =?utf-8?B?MDZOZEVEQ1lyS08wSi82S2lxVjZMQ3pBWGtnMEhUUkJvY00zL1NDUlU0SG11?= =?utf-8?B?Qnl1dnRFMFM3Q080TUJENmZNR255RWZzWVJPMUdEWnNHdWxmbzVob3VhMG9V?= =?utf-8?B?Tk1HUHNlcCtHc3ZSSHg4Y0ltdW9LUlVySVZrZjV1cnlUMHJENlVKcjcwZnBH?= =?utf-8?B?OXNmd3Vka256R2lseVFMQjJldVFSaS96V2wxalF3LzRqOVhrRE8wN3hmdE5n?= =?utf-8?B?d0ZoWllwczZKb2J2eWpLM3V6dkp3SDg1U3NkTHgxR09XckhCck44N1Bkb3F6?= =?utf-8?B?T0dET0t3amVzTTE1bHBKUFpiQmEwTi9rWS9DYUlRNU50OFJ5TWhGOUtKUjlM?= =?utf-8?B?VHFQSnJFU2FBc1kzb0dpUW5Kb05VQlp6WFZXOXpjYVBHcWNXaytoUjEybE5O?= =?utf-8?B?emovYkMxbjZFZURDb0FDOTFMUmNlU2xLU0pEdHZFbGE0MHd1Z0xBR25jUG1W?= =?utf-8?B?UjNYcWszc0Uwd0p4RWU0Yi9xbE9aaStQZWdtczdCMEcrZDdDUlBRN1FOcW5w?= =?utf-8?B?RjZLdUxiM0FqWktpczkxOW0yNVp2MlZTZFg3ZGNnVGh3TkY2SXAzZkxVanBC?= =?utf-8?B?VWNzYmg1Snk2QUNZY21xdDhma2FNODhlWVM4aTRVZ0VzV2FPaDI0MW9qRDVm?= =?utf-8?B?ZGlqekNXNE1oVHZPSlJmQkswWndzODhNMFUwL2ZKa2dFK3hhNXZDWW9sMXJF?= =?utf-8?B?VUZVM2QxYWp3bU5Ta0hJMFNTc0ZneWYyaHdWNWVNVVVZMDBXbnJ4SFN0NWJx?= =?utf-8?B?M3QwYWdNb2hyamZpN1ZSb1k2ZHJDLzZ4ZzN0bTVCMEZVZmVHMnVZdmZtSEdC?= =?utf-8?B?aUlPVEZrcXdqaThNUlVTQ0ZnUlRqQzlLbHF0M3g0ZEFHYmFWaFpvK0dKL2hp?= =?utf-8?B?WkJsLzJHWHVBekZrR3Z3WSs0M2xWUkhHcGJJdjFSd1dZaFZuWmRrR283SFBZ?= =?utf-8?B?M244OStsZ2N2WUQ2R1JtZ01KRk41RDZIZTkzQWJsL01HcXhZL3lrM0poS2k5?= =?utf-8?B?VUpKdzBlVEJjWjZWbHhRamhESnBRWEFya2F6TERUay80NEhyMUZRNlRIWlNP?= =?utf-8?B?dmRuS01QaFVmeU5qQXJMdUJHY3R5WkgyM0tkYndMQmJ5RWM0UFZuV3FoQ1Bk?= =?utf-8?B?RngzUGVtWisyY0htV0JicFNrS001em0wbmhMNnZwSGUrTm5UaFR6Z2I3YXNV?= =?utf-8?B?bGE3V2dVWTA5QzZoblFhNTN4VXA1cU9UbUpGbFQreEltblJnWmJENkNnUlI1?= =?utf-8?B?ZW1YRkxlZDd4K0FPWGpaQXFKa3luT1ZkWFozNjgrbW9GVHJPZmh0blBGZWow?= =?utf-8?B?bStTb3czMkU4TlczbTYzRzJvQy96ZUM5NmJpcmdFSlgrbEh2eEpFRnhxdll4?= =?utf-8?B?L0JNSGhzT3lKdmsxbVZ6L29CQ0xGbEtSWkl1Ym1zdzNWNlFNRjRqY1M3TkhJ?= =?utf-8?Q?zQAOT57IHL1MkXXAKEsKQMifd3k5xX7D5H?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;6:zAB6d7pOvR5x37/oUAxrAcG76aGoCHtJjbxFrn/vxl5X4m9QGm2o7Mjmm3HybQwfr1qnGyhsglD9KeN0W0ozSeQbeE6KKN3MGSxWT4vZjT6aa5aDfq8K1AY79P+wcPgxUQ/iy0LtDBR+wXrBlU9Xs5C3M6C4c978gZQMEJ5PYNiIglR7qL6b+/akub3i8sHu90cmh9DT+k9F+r950ZLeX9axegASfSNdp+XMeu+gp2ybnDIp8DbJbl0UUO90/Dx/1cub7kzWGWGqCSo/RY3lOg750hmJzwoUbBQrZV+pPmTtS0hMRjTzt6X8mjnJKhTz;5:iU2T+AFeX86iFDulvB0y6Nk/wSmjyVjrcbflH/OMHj5GiIeL0NDoIgqYqLd9rKgyTqo0/MQZDzYpAC9iWtbL0JkjMm9vB47wsXDvenvCR3XREK8kVFfD0mcexgjWW4layA1CSdCcKgLuFOHuLWF8Fg==;24:qPOC494HzTopceDKjzqPOHN7eUY6jRggyizLJ2Sb31HByXJNfAuiTXmPZNHcaGpXckDD1f2SzCPpz0BNdksNVIC1u+t6756ReJdsPEv6x4U=;7:sdA3dWKCJRKj4kQXEjR7bDzC06UP56GHm7LHz0Q9hE8fep4Jiky/cfRUkrozqzZcOWlKoi3pzhvTis4B3WBf0Ccre+C69KcEMOf7Q0AWPs4l4ZzbinbG4z2BQaU+404VoCSidqyTs/0orXhjytEw6xPze2UVxw6wXm2kxz7+vKpc7+GaezYCa7pbXwPoj99lojjuruCFtOG9GWkDmehyoaHXNI2g3+qqYdWOwMHQO6EhkL73/BbtMyRXvTFfJduQ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2016 10:43:33.1523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0201MB2312 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-09-06 10:20, Neil Armstrong wrote: > Hi Linus, Peter, > > On 09/06/2016 08:44 AM, Peter Rosin wrote: >> I intend to test this, but it might be a couple of days. I need >> to bring the damn thing out of the closet and find the right >> cables etc etc. And I of course have other stuff to do as well... > > Is it a DT only platform you intent to test with ? In this case the current version is OK. Yes, it's DT-only, but I don't expect it to be compatible as I linked the wrong patch, see below... *snip* >> No, we have not, because we depend on yet to be upstreamed drivers >> for all of our boards, sometimes written by us, sometimes from >> the CPU vendor. For this driver, we were using a rejected patch >> to configure the pins from DT in the gpio driver written by >> Wei Chen [1] > > Actually it seems the patch was accepted, but it is not enough to handle > DT completely since the gpio base is incorrect, this was the subject > of my previous patch [2], make is DT compliant even for IRQ management. > But having a pinctrl version seens far more reasonable. Oh crap, wrong link... Here's a better one: https://patchwork.kernel.org/patch/5437921/ >> One thing I noted at the very end of the patch was that I on >> first glance did not see any i2c_del_driver call, maybe use the >> module_i2c_driver macro? > > Well, it's not present in the gpio version and since it manages IRQs, I assume it was > decided to not use is as a module since it's needed to attach very early. I just noted the omission, someone else will shirley know better than me about what to do about it... (BTW, we're not using interrupts) Cheers, Peter