From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 106C0C761A6 for ; Mon, 17 Feb 2020 13:02:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E23B320578 for ; Mon, 17 Feb 2020 13:02:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728918AbgBQNC1 (ORCPT ); Mon, 17 Feb 2020 08:02:27 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:9038 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728217AbgBQNC1 (ORCPT ); Mon, 17 Feb 2020 08:02:27 -0500 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01HCrsBs179663 for ; Mon, 17 Feb 2020 08:02:26 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2y6cu1pcma-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 17 Feb 2020 08:02:25 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 17 Feb 2020 13:02:23 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 17 Feb 2020 13:02:18 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 01HD2GVI49348804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 17 Feb 2020 13:02:16 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9CFE2A404D; Mon, 17 Feb 2020 13:02:16 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6B353A4055; Mon, 17 Feb 2020 13:02:12 +0000 (GMT) Received: from [9.199.62.136] (unknown [9.199.62.136]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 17 Feb 2020 13:02:12 +0000 (GMT) Subject: Re: [PATCH 0/8] perf annotate/config: More fixes To: Jiri Olsa Cc: acme@kernel.org, xieyisheng1@huawei.com, alexey.budankov@linux.intel.com, treeze.taeung@gmail.com, adrian.hunter@intel.com, tmricht@linux.ibm.com, namhyung@kernel.org, irogers@google.com, songliubraving@fb.com, yao.jin@linux.intel.com, changbin.du@intel.com, leo.yan@linaro.org, linux-kernel@vger.kernel.org, Ravi Bangoria References: <20200213064306.160480-1-ravi.bangoria@linux.ibm.com> <20200216211549.GA157041@krava> From: Ravi Bangoria Date: Mon, 17 Feb 2020 18:32:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200216211549.GA157041@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 20021713-4275-0000-0000-000003A2C7FC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20021713-4276-0000-0000-000038B6CC5C Message-Id: <392dfffd-6063-c778-26eb-c9cd886b9e5a@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-17_07:2020-02-17,2020-02-17 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 mlxscore=0 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 clxscore=1015 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002170109 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/17/20 2:45 AM, Jiri Olsa wrote: > On Thu, Feb 13, 2020 at 12:12:58PM +0530, Ravi Bangoria wrote: >> These are the additional set of fixes on top of previous series: >> http://lore.kernel.org/r/20200204045233.474937-1-ravi.bangoria@linux.ibm.com >> >> Note for the last patch: >> I couldn't understand what intel-pt.cache-divisor is really used for. >> Adrian, can you please help. >> >> Ravi Bangoria (8): >> perf annotate/tui: Re-render title bar after switching back from >> script browser >> perf annotate: Fix --show-total-period for tui/stdio2 >> perf annotate: Fix --show-nr-samples for tui/stdio2 >> perf config: Introduce perf_config_u8() >> perf annotate: Make perf config effective >> perf annotate: Prefer cmdline option over default config >> perf annotate: Fix perf config option description >> perf config: Document missing config options > > nice, I guess this all worked in the past but got broken because > we don't have any tests for annotation code.. any chance you could > think of some way to test annotations? > > perhaps some shell script, or prepare all the needed data for annotation > manualy.. sort of like we did in tests/hists_*.c Sure Jiri. I'll take a look at this. Ravi