From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B540C433FE for ; Wed, 22 Sep 2021 15:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F3B1611CA for ; Wed, 22 Sep 2021 15:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236439AbhIVPb7 (ORCPT ); Wed, 22 Sep 2021 11:31:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:53650 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236400AbhIVPb7 (ORCPT ); Wed, 22 Sep 2021 11:31:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632324628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d3JsLpxzQ+uhSu3TGOCWtptCmz4xP0JT6j/hot5bD5w=; b=BwD2cZWvnbp6icZN7rR1YOW2VoSQvSJks460NA1mERvpBB2Lxdjc0Cs69Ap8PpOqVozPdK +BwRDIbu31o6pwYCfzb6gRB150ai8nbuUl0Ts4WEgN3E1WVPeETkq4t3/+ZdPchRDun8PG n8IMX8Dtj/JMJUbD7PT9SDxmU3JVF7U= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-hiFa0IYlPCOXniSbBzZzRQ-1; Wed, 22 Sep 2021 11:30:27 -0400 X-MC-Unique: hiFa0IYlPCOXniSbBzZzRQ-1 Received: by mail-ed1-f69.google.com with SMTP id n5-20020a05640206c500b003cf53f7cef2so3476933edy.12 for ; Wed, 22 Sep 2021 08:30:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d3JsLpxzQ+uhSu3TGOCWtptCmz4xP0JT6j/hot5bD5w=; b=UtGeMDLSierxEj9xziUSad/a3px6qtLK6dOZxwfiQBkBc/koCS8jcxV20NXHU8+imy EINQxXeM8JhWQfspvyGaTYavuPRrRjZHh8YGdlDVzsu9TAmzwZUeM8berPHULDs4bFq3 As3Uuk8cNUdIq0xCybBb8NCpbHIMPRHKqEPO1K7duXxm6U06pPXJZVuZGNu2zAJv+8Lw ybHY5Gpiu+j/2x+z9smeCCFLTrp7D6jtEp6wL8lANrQAt+apjQHgJ9WYyPBYqQ4+5+jM hzLZMCzjl0P4D5l2zr14hklE1XRZ0/E6yMJh8B3zMFZiU4HUofqXg5Tx1vsDtr87K28U D/NQ== X-Gm-Message-State: AOAM531NyiJvxq4TQAkRI47cw0ps9DlRuZ4Flj/rB6wEvGsBZn2kxNAT XLrsACVXOuy/B18kLHQiMHlFvwePBSz/FLRIjkaXD8GYr2Hf0+6IM0JtZYwxXo/8ZktCKY6R9i2 /5e3daEADu8PsmbctAC5tIfWvuQeBSmYyT/1Q+2nDaE4+T2EOvno6xdmdWtfR57QXApqPjI4zLh De X-Received: by 2002:a50:c31c:: with SMTP id a28mr216103edb.384.1632324626023; Wed, 22 Sep 2021 08:30:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw02+/MQdKVUxCJnsyoBcCJU+R107o2lVynj8H1Ua46GB1mUTBMgqeB9rChSSQAr9JrISxe/g== X-Received: by 2002:a50:c31c:: with SMTP id a28mr216042edb.384.1632324625725; Wed, 22 Sep 2021 08:30:25 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n13sm1186280ejk.97.2021.09.22.08.30.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 08:30:25 -0700 (PDT) Subject: Re: [PATCH] kvm: x86: Add AMD PMU MSRs to msrs_to_save_all[] To: Fares Mehanna , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210915133951.22389-1-faresx@amazon.de> From: Paolo Bonzini Message-ID: <3932c56b-a12a-904d-b727-1dad2b1d35b1@redhat.com> Date: Wed, 22 Sep 2021 17:30:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210915133951.22389-1-faresx@amazon.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/09/21 15:39, Fares Mehanna wrote: > Intel PMU MSRs is in msrs_to_save_all[], so add AMD PMU MSRs to have a > consistent behavior between Intel and AMD when using KVM_GET_MSRS, > KVM_SET_MSRS or KVM_GET_MSR_INDEX_LIST. > > We have to add legacy and new MSRs to handle guests running without > X86_FEATURE_PERFCTR_CORE. > > Signed-off-by: Fares Mehanna > --- > arch/x86/kvm/x86.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 28ef14155726..14bc21fb698c 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -1332,6 +1332,13 @@ static const u32 msrs_to_save_all[] = { > MSR_ARCH_PERFMON_EVENTSEL0 + 12, MSR_ARCH_PERFMON_EVENTSEL0 + 13, > MSR_ARCH_PERFMON_EVENTSEL0 + 14, MSR_ARCH_PERFMON_EVENTSEL0 + 15, > MSR_ARCH_PERFMON_EVENTSEL0 + 16, MSR_ARCH_PERFMON_EVENTSEL0 + 17, > + > + MSR_K7_EVNTSEL0, MSR_K7_EVNTSEL1, MSR_K7_EVNTSEL2, MSR_K7_EVNTSEL3, > + MSR_K7_PERFCTR0, MSR_K7_PERFCTR1, MSR_K7_PERFCTR2, MSR_K7_PERFCTR3, > + MSR_F15H_PERF_CTL0, MSR_F15H_PERF_CTL1, MSR_F15H_PERF_CTL2, > + MSR_F15H_PERF_CTL3, MSR_F15H_PERF_CTL4, MSR_F15H_PERF_CTL5, > + MSR_F15H_PERF_CTR0, MSR_F15H_PERF_CTR1, MSR_F15H_PERF_CTR2, > + MSR_F15H_PERF_CTR3, MSR_F15H_PERF_CTR4, MSR_F15H_PERF_CTR5, > }; > > static u32 msrs_to_save[ARRAY_SIZE(msrs_to_save_all)]; > Queued, thanks. Paolo