From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932143AbdBHKXE (ORCPT ); Wed, 8 Feb 2017 05:23:04 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:40800 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752404AbdBHKVr (ORCPT ); Wed, 8 Feb 2017 05:21:47 -0500 Subject: Re: [PATCH v4 1/8] ASoC: sun4i-i2s: Update binding documentation to include A31 To: broonie@kernel.org References: <20170202092422.5588-1-mylene.josserand@free-electrons.com> <20170202092422.5588-2-mylene.josserand@free-electrons.com> Cc: lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@free-electrons.com, alexandre.belloni@free-electrons.com From: Mylene Josserand Message-ID: <39416532-9020-6e5c-e6ce-4e4264612ac1@free-electrons.com> Date: Wed, 8 Feb 2017 11:10:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170202092422.5588-2-mylene.josserand@free-electrons.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mark Brown, Thank you to have applied my patches! On 02/02/2017 10:24, Mylène Josserand wrote: > Add a new compatible for sun4i-i2s driver to handle some > SoCs that have a reset line that must be asserted/deasserted. > > This new compatible, "allwinner,sun6i-a31-i2s", requires the > property "resets" which should be a phandle to the reset line. > Except these differences, the compatible is identical to previous one > which will not handle a reset line. > > Signed-off-by: Mylène Josserand > Acked-by: Maxime Ripard > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/sound/sun4i-i2s.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt > index 7b526ec64991..f4adc58f82ba 100644 > --- a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt > +++ b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt > @@ -7,6 +7,7 @@ Required properties: > > - compatible: should be one of the followings > - "allwinner,sun4i-a10-i2s" > + - "allwinner,sun6i-a31-i2s" > - reg: physical base address of the controller and length of memory mapped > region. > - interrupts: should contain the I2S interrupt. > @@ -19,6 +20,10 @@ Required properties: > - "mod" : module clock for the I2S controller > - #sound-dai-cells : Must be equal to 0 > > +Required properties for the following compatibles: > + - "allwinner,sun6i-a31-i2s" > +- resets: phandle to the reset line for this codec > + > Example: > > i2s0: i2s@01c22400 { > For all my series, you did not pick-up this patch. I was wondering if you have any comment on it? Is there something wrong? Thank you in advance, Best regards, -- Mylène Josserand, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com