From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S945452AbdDTMtL (ORCPT ); Thu, 20 Apr 2017 08:49:11 -0400 Received: from mga03.intel.com ([134.134.136.65]:47524 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938373AbdDTMtJ (ORCPT ); Thu, 20 Apr 2017 08:49:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,225,1488873600"; d="scan'208";a="1138098708" Subject: Re: [PATCH v8 3/6] i2c: designware: MASTER mode as separated driver To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com From: Jarkko Nikula Message-ID: <3963c4b3-0ca7-8a97-825c-09dde3472554@linux.intel.com> Date: Thu, 20 Apr 2017 15:49:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/12/2017 07:47 PM, Luis Oliveira wrote: > - The functions related to I2C master mode of operation were transformed > in a single driver. > - Common definitions were moved to i2c-designware-core.h > - The i2c-designware-core is now only a library file, the functions > associated are in a source file called i2c-designware-common and > are used by both i2c-designware-master and i2c-designware-slave. > - To decrease noise in namespace common i2c_dw_*() functions are > now using ops to keep them private. > - Designware PCI driver had to be changed to match the previous ops > functions implementation. > > Almost all of the "core" source is now part of the "master" source. The > difference is the functions used by both modes and they are in the > "common" source file. > > Signed-off-by: Luis Oliveira > Acked-by: Andy Shevchenko > --- > v7-v8 > - removed "@dynamic_tar_update_enabled" comment > > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-designware-common.c | 274 +++++++++++++++ > drivers/i2c/busses/i2c-designware-core.h | 145 +++++++- > ...c-designware-core.c => i2c-designware-master.c} | 367 +-------------------- > drivers/i2c/busses/i2c-designware-pcidrv.c | 8 +- > drivers/i2c/busses/i2c-designware-platdrv.c | 6 +- > 6 files changed, 432 insertions(+), 369 deletions(-) > create mode 100644 drivers/i2c/busses/i2c-designware-common.c > rename drivers/i2c/busses/{i2c-designware-core.c => i2c-designware-master.c} (65%) > Acked-by: Jarkko Nikula