From: <Eugen.Hristev@microchip.com>
To: <linmq006@gmail.com>
Cc: <mchehab@kernel.org>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <hverkuil-cisco@xs4all.nl>,
<linux-media@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] media: atmel: atmel-isc: Fix PM disable depth imbalance in atmel_isc_probe
Date: Wed, 2 Mar 2022 06:17:49 +0000 [thread overview]
Message-ID: <396f655f-6baa-d974-960d-5b436325e2d5@microchip.com> (raw)
In-Reply-To: <20220302054457.GA1088@VICKYMQLIN-NB1.localdomain>
On 3/2/22 7:44 AM, Miaoqian Lin wrote:
> On Tue, Mar 01, 2022 at 01:51:02PM +0000, Eugen.Hristev@microchip.com wrote:
>>> ---
>>> changes in v2:
>>> - remove unused label.
>>> ---
>>> drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
>>> index 1b2063cce0f7..7f1ebbb25437 100644
>>> --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c
>>> +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c
>>> @@ -559,6 +559,8 @@ static int atmel_isc_probe(struct platform_device *pdev)
>>> cleanup_subdev:
>>> isc_subdev_cleanup(isc);
>>>
>>> + pm_runtime_disable(dev);
>>> +
>>
>> Hello Miaoqian Lin ,
>>
>> Could you please perform the same change (or similar) in
>> atmel-sama7g5-isc , as the sama7g5 ISC will perform the same and has the
>> same bug.
>>
> Hi, Eugen Hristev:
>
> I think you are referring to microchip_xisc_probe() function in
> atmel-sama7g5-isc, and I have look into it. After it calls
> pm_runtime_enable(), it only have a regular path whichs return 0 and
> indicates
> the probe is successful. It doesn't have error handling path.
Hi,
You are right. It will always have a success path.
Your patch is fine for me :
Reviewed-by: Eugen Hristev <eugen.hristev@microchip.com>
Thanks !
>
> regmap_read() function returns a negative errno in error cases, but it
> is used to get Microchip XISC version. I am not sure if failure means
> the probe fails.
>>> unregister_v4l2_device:
>>> v4l2_device_unregister(&isc->v4l2_dev);
>>>
>>> --
>>> 2.17.1
>>>
>>
next prev parent reply other threads:[~2022-03-02 6:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 11:10 [PATCH] media: atmel: atmel-isc: Fix PM disable depth imbalance in atmel_isc_probe Miaoqian Lin
2022-01-06 12:42 ` kernel test robot
2022-03-01 7:18 ` [PATCH v2] " Miaoqian Lin
2022-03-01 13:51 ` Eugen.Hristev
2022-03-02 5:44 ` Miaoqian Lin
2022-03-02 6:17 ` Eugen.Hristev [this message]
2022-03-07 7:38 ` Hans Verkuil
2022-03-07 8:16 ` [PATCH v3] " Miaoqian Lin
2022-05-09 19:13 ` Eugen.Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=396f655f-6baa-d974-960d-5b436325e2d5@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).