From: Jerome Brunet <jbrunet@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
narmstrong@baylibre.com, linux-amlogic@lists.infradead.org,
mjourdan@baylibre.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] clk: meson8b: add the video decoder clocks
Date: Mon, 25 Mar 2019 11:01:57 +0100 [thread overview]
Message-ID: <39732b0ea1d10bd91423ca80b61abf5545965dda.camel@baylibre.com> (raw)
In-Reply-To: <20190324151423.19063-1-martin.blumenstingl@googlemail.com>
On Sun, 2019-03-24 at 16:14 +0100, Martin Blumenstingl wrote:
> This adds the video decoder clocks for Meson8, Meson8b and Meson8m2.
>
> The clock tree on Meson8 differs from the one one Meson8b and Meson8m2.
> Details can be found in patch #2.
>
> There are some checkpatch warnings in patch #2:
> WARNING: please, no space before tabs
> I decided to still send the patch because we have the same inconsistency
> with all other clk_hw_onecell_data table entries. Please let me know if
> I should come up with a follow-up patch to clean them all up.
A cleanup patch is always appreciated :) Before or after your changes, I don't
really mind. Up to you.
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
>
> Testing:
> I have not tested this with Maxime's video decoder driver yet.
> However, I manually enabled and set various frequencies for the HCODEC
> clock and verified that clkmsr reports the correct rate.
>
> Dependencies:
> This is meant to be applied on top of my other series from [0]:
> clk: meson8b: add the VPU clock tree
>
> Changes since v1 at [1]:
> - collected Neil's and Maxime's Reviewed-by (thank you!)
>
>
> [0] https://patchwork.kernel.org/cover/10860401/
> [1] https://patchwork.kernel.org/cover/10860513/
>
>
> Martin Blumenstingl (2):
> dt-bindings: clock: meson8b: export the video decoder clocks
> clk: meson: meson8b: add the video decoder clock trees
>
> drivers/clk/meson/meson8b.c | 312 +++++++++++++++++++++++
> drivers/clk/meson/meson8b.h | 17 +-
> include/dt-bindings/clock/meson8b-clkc.h | 4 +
> 3 files changed, 332 insertions(+), 1 deletion(-)
>
next prev parent reply other threads:[~2019-03-25 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 15:14 [PATCH v2 0/2] clk: meson8b: add the video decoder clocks Martin Blumenstingl
2019-03-24 15:14 ` [PATCH v2 1/2] dt-bindings: clock: meson8b: export " Martin Blumenstingl
2019-03-31 6:41 ` Rob Herring
2019-03-24 15:14 ` [PATCH v2 2/2] clk: meson: meson8b: add the video decoder clock trees Martin Blumenstingl
2019-03-25 10:01 ` Jerome Brunet [this message]
2019-04-01 8:43 ` [PATCH v2 0/2] clk: meson8b: add the video decoder clocks Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39732b0ea1d10bd91423ca80b61abf5545965dda.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mjourdan@baylibre.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).