From: Jarmo Tiitto <jarmo.tiitto@gmail.com>
To: Nathan Chancellor <nathan@kernel.org>, Kees Cook <keescook@chromium.org>
Cc: Jarmo Tiitto <jarmo.tiitto@gmail.com>,
Sami Tolvanen <samitolvanen@google.com>,
Bill Wendling <wcw@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org,
morbo@google.com
Subject: Re: [PATCH v2 1/1] pgo: Fix allocate_node() v2
Date: Fri, 04 Jun 2021 12:40:27 +0300 [thread overview]
Message-ID: <3979125.JPf0czqrma@hyperiorarchmachine> (raw)
In-Reply-To: <202106031436.132E0ED9A@keescook>
Kees Cook wrote perjantaina 4. kesäkuuta 2021 0.36.39 EEST:
> On Thu, Jun 03, 2021 at 02:14:24PM -0700, Nathan Chancellor wrote:
> > On 6/3/2021 6:38 AM, Jarmo Tiitto wrote:
> > > Based on Kees and others feedback here is v2 patch
> > > that clarifies why the current checks in allocate_node()
> > > are flawed. I did fair amount of KGDB time on it.
> > >
> > > When clang instrumentation eventually calls allocate_node()
> > > the struct llvm_prf_data *p argument tells us from what section
> > > we should reserve the vnode: It either points into vmlinux's
> > > core __llvm_prf_data section or some loaded module's
> > > __llvm_prf_data section.
> > >
> > > But since we don't have access to corresponding
> > > __llvm_prf_vnds section(s) for any module, the function
> > > should return just NULL and ignore any profiling attempts
> > > from modules for now.
> > >
> > > Signed-off-by: Jarmo Tiitto <jarmo.tiitto@gmail.com>
> >
> > I agree with Nick on the comments about the commit message. A few more small
> > nits below, not sure they necessitate a v3, up to you. Thank you for the
> > patch!
>
> It would make my life easier to get a v3. :) I agree with all of
> Nathan's suggestions. :)
>
> Thanks!
>
> -Kees
>
> --
> Kees Cook
>
Hello,
Ok, I'll make the requested changes, noted by Nathan and post v3 patch soon. :-)
Btw. These patches were based on kees/for-next/clang/features branch.
Thanks for patience.
-Jarmo
prev parent reply other threads:[~2021-06-04 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 13:38 [PATCH v2 1/1] pgo: Fix allocate_node() v2 Jarmo Tiitto
2021-06-03 20:50 ` Nick Desaulniers
2021-06-03 20:52 ` Nathan Chancellor
2021-06-03 21:00 ` Nick Desaulniers
2021-06-03 21:14 ` Nathan Chancellor
2021-06-03 21:36 ` Kees Cook
2021-06-04 9:40 ` Jarmo Tiitto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3979125.JPf0czqrma@hyperiorarchmachine \
--to=jarmo.tiitto@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
--cc=wcw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).