From: Jon Hunter <jonathanh@nvidia.com>
To: Peter Zijlstra <peterz@infradead.org>, Sachin Nikam <Snikam@nvidia.com>
Cc: Ketan Patil <ketanp@nvidia.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Bharat Nihalani <bnihalani@nvidia.com>, Bo Yan <byan@nvidia.com>,
Sai Gurrappadi <sgurrappadi@nvidia.com>,
Thierry Reding <treding@nvidia.com>, Timo Alho <talho@nvidia.com>
Subject: Re: [PATCH] sched/cputime: Remove unnecessary assignment statement
Date: Thu, 28 Feb 2019 13:53:31 +0000 [thread overview]
Message-ID: <397917cc-3656-e26c-7715-d4feec97bb4b@nvidia.com> (raw)
In-Reply-To: <20190228123120.GA32494@hirez.programming.kicks-ass.net>
On 28/02/2019 12:31, Peter Zijlstra wrote:
>
> Clearly, because reading comprehension isn't your strong point:
>
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
Sorry we have a few people helping out cleaning up our kernel branches
and we need to do a better job here indeed!
> On Thu, Feb 28, 2019 at 12:14:09PM +0000, Sachin Nikam wrote:
>
>> This isn't a security fix.
>> However, I see this is kind of code cleanup.
>
> As I've explained previously, it makes conceptual sense to have it in
> the code, and any halfway sane compiler will observe the same double
> store and eliminate it in its DCE pass.
OK. Thanks for the feedback. We can agree to drop this and we will try
to do a better job reviewing this type of thing before hand in future.
Cheers
Jon
--
nvpublic
prev parent reply other threads:[~2019-02-28 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 6:13 [PATCH] sched/cputime: Remove unnecessary assignment statement Ketan Patil
2019-02-27 10:32 ` Peter Zijlstra
2019-02-28 9:42 ` Ketan Patil
2019-02-28 9:47 ` Peter Zijlstra
2019-02-28 12:14 ` Sachin Nikam
2019-02-28 12:31 ` Peter Zijlstra
2019-02-28 13:53 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=397917cc-3656-e26c-7715-d4feec97bb4b@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=Snikam@nvidia.com \
--cc=bnihalani@nvidia.com \
--cc=byan@nvidia.com \
--cc=ketanp@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sgurrappadi@nvidia.com \
--cc=talho@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).