From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01EC6C3B186 for ; Tue, 11 Feb 2020 16:14:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDD652070A for ; Tue, 11 Feb 2020 16:14:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730718AbgBKQOM (ORCPT ); Tue, 11 Feb 2020 11:14:12 -0500 Received: from mga14.intel.com ([192.55.52.115]:36060 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728206AbgBKQOL (ORCPT ); Tue, 11 Feb 2020 11:14:11 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 08:14:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="233497223" Received: from djiang5-desk3.ch.intel.com ([143.182.136.137]) by orsmga003.jf.intel.com with ESMTP; 11 Feb 2020 08:14:08 -0800 Subject: Re: [PATCH -next] dmaengine: idxd: remove set but not used variable 'group' To: YueHaibing , dan.j.williams@intel.com, vkoul@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200211135335.55924-1-yuehaibing@huawei.com> From: Dave Jiang Message-ID: <397d824a-8827-c5b8-4dda-60fe79c6512d@intel.com> Date: Tue, 11 Feb 2020 09:14:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200211135335.55924-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/20 6:53 AM, YueHaibing wrote: > drivers/dma/idxd/sysfs.c: In function engine_group_id_store: > drivers/dma/idxd/sysfs.c:419:29: warning: variable group set but not used [-Wunused-but-set-variable] > > It is not used, so remove it. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Acked-by: Dave Jiang > --- > drivers/dma/idxd/sysfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c > index 6d907fe..e4f35bd 100644 > --- a/drivers/dma/idxd/sysfs.c > +++ b/drivers/dma/idxd/sysfs.c > @@ -416,7 +416,7 @@ static ssize_t engine_group_id_store(struct device *dev, > struct idxd_device *idxd = engine->idxd; > long id; > int rc; > - struct idxd_group *prevg, *group; > + struct idxd_group *prevg; > > rc = kstrtol(buf, 10, &id); > if (rc < 0) > @@ -436,7 +436,6 @@ static ssize_t engine_group_id_store(struct device *dev, > return count; > } > > - group = &idxd->groups[id]; > prevg = engine->group; > > if (prevg) >