From: Bart Van Assche <bvanassche@acm.org>
To: Martijn Coenen <maco@android.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Ming Lei <ming.lei@redhat.com>,
Narayan Kamath <narayan@google.com>,
Zimuzo Ezeozue <zezeozue@google.com>,
kernel-team@android.com,
linux-block <linux-block@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Martijn Coenen <maco@google.com>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [PATCH 1/4] loop: Refactor size calculation.
Date: Tue, 21 Apr 2020 08:26:22 -0700 [thread overview]
Message-ID: <398b9d9e-bb7c-6b95-4766-3e9bf2769a61@acm.org> (raw)
In-Reply-To: <CAB0TPYHXCRq-SVGsNBviyCAyP75oKam77W9vdsyri9fzA2tp+g@mail.gmail.com>
On 4/21/20 4:48 AM, Martijn Coenen wrote:
> On Mon, Apr 20, 2020 at 3:22 PM Bart Van Assche <bvanassche@acm.org> wrote:
>> Please also change the "kill_bdev should have truncated all the pages"
>> comment into something like "return -EAGAIN if any pages have been
>> dirtied after kill_bdev() returned".
>
> Sure - would you prefer this to be in a separate change?
Since the comment "kill_bdev should have truncated all the pages" has to
be moved, I think that it's fine to integrate the fix for that comment
in this patch.
Thanks,
Bart.
next prev parent reply other threads:[~2020-04-21 15:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 8:04 [PATCH 0/4] Add a new LOOP_SET_FD_AND_STATUS ioctl Martijn Coenen
2020-04-20 8:04 ` [PATCH 1/4] loop: Refactor size calculation Martijn Coenen
2020-04-20 13:22 ` Bart Van Assche
2020-04-21 11:48 ` Martijn Coenen
2020-04-21 15:26 ` Bart Van Assche [this message]
2020-04-20 8:04 ` [PATCH 2/4] loop: Factor out configuring loop from status Martijn Coenen
2020-04-20 13:34 ` Bart Van Assche
2020-04-20 13:49 ` Bart Van Assche
2020-04-21 11:46 ` Martijn Coenen
2020-04-20 8:04 ` [PATCH 3/4] loop: Move loop_set_from_status() and friends up Martijn Coenen
2020-04-20 13:43 ` Bart Van Assche
2020-04-20 8:04 ` [PATCH 4/4] loop: Add LOOP_SET_FD_AND_STATUS ioctl Martijn Coenen
2020-04-22 6:19 ` Christoph Hellwig
2020-04-22 8:06 ` Martijn Coenen
2020-04-22 8:07 ` Christoph Hellwig
2020-04-22 15:10 ` Bart Van Assche
2020-04-27 7:42 ` Martijn Coenen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=398b9d9e-bb7c-6b95-4766-3e9bf2769a61@acm.org \
--to=bvanassche@acm.org \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=maco@google.com \
--cc=ming.lei@redhat.com \
--cc=narayan@google.com \
--cc=zezeozue@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).