From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Inki Dae <inki.dae@samsung.com>, krzk@kernel.org
Cc: kgene@kernel.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, b.zolnierkie@samsung.com,
m.szyprowski@samsung.com
Subject: Re: [PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node
Date: Fri, 09 Mar 2018 12:52:58 +0100 [thread overview]
Message-ID: <39965bce-a6f2-6202-5c3f-97e4446e97eb@samsung.com> (raw)
In-Reply-To: <5AA1F41B.5080104@samsung.com>
Hi Inki,
On 03/09/2018 03:40 AM, Inki Dae wrote:
> 2018년 03월 08일 02:27에 Sylwester Nawrocki 이(가) 쓴 글:
>> This property is required for specifying link between the HDMI IP block
>> and the SoC's audio subsystem.
>>
>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5250.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
>> index 56626d1a4235..71d2ede118e3 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -700,6 +700,7 @@
>> "sclk_hdmiphy", "mout_hdmi";
>> samsung,syscon-phandle = <&pmu_system_controller>;
>> phy = <&hdmiphy>;
>> + #sound-dai-cells = <0>;
>
> This patch adds this property to hdmi device node which is bound by HDMI driver
> of Exynos DRM. As we talked about this at other email thread, seems this property
> is required mandatorily for Odroid XU3/4 board which uses Exynos5422.
> There may be something I'm missing so could you let me know how this property
> is required?
It is required to properly interpret the list of DAI specified in the 'sound-dai'
property. If a device supports only one DAI it will have #sound-dai-cells = <0>
and the sound-dai property values in cpu<->codec link may look like this:
cpu { ... }
codec {
sound-dai = <&max98090>, <&hdmi>;
};
When the CODEC support more DAIs it will have #sound-dai-cells = <1> and we can
additionally specify which DAI we exactly refer to, in this case DAI 0:
cpu { ... }
codec {
sound-dai = <&max98095 0>, <&hdmi>;
};
More details can be found in documentation of of_parse_phandle_with_args()
function.
The above refers to cpu/codec mapping like I2S0 -> [max9809x, hdmi], on Exynos5433
we have I2S0 -> wm5110 and I2S1 -> hdmi.
--
Regards,
Sylwester
next prev parent reply other threads:[~2018-03-09 11:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180307172723epcas1p1b8879bb555737cab7406a172b7d13a56@epcas1p1.samsung.com>
2018-03-07 17:27 ` [PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node Sylwester Nawrocki
[not found] ` <CGME20180307172734epcas1p49c88df114f4e3b32999fbfb6159773ed@epcas1p4.samsung.com>
2018-03-07 17:27 ` [PATCH 2/4] ARM: dts: Add audio clocks configuration for exynos5250-snow Sylwester Nawrocki
[not found] ` <CGME20180307172738epcas2p20b57ae0b00fc1a422cd3e9b1b297753c@epcas2p2.samsung.com>
2018-03-07 17:27 ` [PATCH 3/4] ARM: dts: exynos5250-snow MAX98095 CODEC node update Sylwester Nawrocki
[not found] ` <CGME20180307172742epcas2p2c0ef2394412da71b6d0ee172c47c3420@epcas2p2.samsung.com>
2018-03-07 17:27 ` [PATCH 4/4] ARM: dts: Enable HDMI audio on Snow Chromebook Sylwester Nawrocki
2018-03-08 11:39 ` Sylwester Nawrocki
[not found] ` <CGME20180308162609epcas1p45458c1671c38b389e047f17804690eb9@epcas1p4.samsung.com>
2018-03-08 16:25 ` [PATCH v2 " Sylwester Nawrocki
2018-03-09 13:01 ` Krzysztof Kozlowski
2018-03-09 15:09 ` Sylwester Nawrocki
2018-03-09 2:40 ` [PATCH 1/4] ARM: dts: exynos5250: Add #sound-dai-cells property to hdmi device node Inki Dae
2018-03-09 11:52 ` Sylwester Nawrocki [this message]
2018-03-12 0:48 ` Inki Dae
2018-03-14 10:33 ` Sylwester Nawrocki
2018-03-09 12:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39965bce-a6f2-6202-5c3f-97e4446e97eb@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=inki.dae@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).