From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752446AbcKHHSg (ORCPT ); Tue, 8 Nov 2016 02:18:36 -0500 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:55220 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbcKHHSe (ORCPT ); Tue, 8 Nov 2016 02:18:34 -0500 X-ME-Helo: [127.0.0.1] X-ME-Date: Tue, 08 Nov 2016 08:18:07 +0100 X-ME-IP: 92.140.227.116 Subject: Re: [PATCH] serial: sirf: Simplify a test To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <20161101070333.12255-1-christophe.jaillet@wanadoo.fr> <2916662.De1FDumaQl@wuerfel> Cc: baohua@kernel.org, gregkh@linuxfoundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, jslaby@suse.com Newsgroups: gmane.linux.ports.arm.kernel,gmane.linux.kernel.janitors,gmane.linux.kernel,gmane.linux.serial From: Christophe JAILLET Message-ID: <39a1050e-fb64-a6e5-8939-4e01631e59ea@wanadoo.fr> Date: Tue, 8 Nov 2016 08:18:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <2916662.De1FDumaQl@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Antivirus: avast! (VPS 161107-1, 07/11/2016), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 07/11/2016 à 14:50, Arnd Bergmann a écrit : > On Tuesday, November 1, 2016 8:03:33 AM CET Christophe JAILLET wrote: >> 'dmaengine_prep_dma_cyclic()' does not return an error pointer, so the test >> can be simplified to be more consistent. >> >> Signed-off-by: Christophe JAILLET > The change looks correct in principle. It would be good to automate looking > for other instances of this bug. How did you find it? Do you have e.g. a > coccinelle script or did you just stumble over the issue by accident? Hi, You can have an idea of the strategy used in this post: https://lkml.org/lkml/2016/11/1/388 Julia is currently working on a more complete strategy in order to find such issues. In the meantime, if you want, I can send the coccinelle scripts used. Best regards, CJ