From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB1AC4338F for ; Tue, 3 Aug 2021 07:58:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A43E60EC0 for ; Tue, 3 Aug 2021 07:58:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234148AbhHCH6z (ORCPT ); Tue, 3 Aug 2021 03:58:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27722 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234269AbhHCH6y (ORCPT ); Tue, 3 Aug 2021 03:58:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627977523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4067Q/uBr5whrrksAorpAMgFNv8fx79XPkLrnKf4gpY=; b=GsYFhZt0eeN7o6OmcSp59Y3ZBqGFQJPDhZgS3Z0hWFoJuGkoqWS9w+upgFHXJGjMTDac++ XAJ07zL6HQiAkQFSyyinvydU+J0PqWiaSmmyB/Zve7namqIHO+533Mw5BDqK/aVe3BLYu/ nBo96LvmrcVOXaI23SHi/QClOF8f+Vo= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-527-j-NQOmwTOr63DbsrCUtMLg-1; Tue, 03 Aug 2021 03:58:42 -0400 X-MC-Unique: j-NQOmwTOr63DbsrCUtMLg-1 Received: by mail-pj1-f72.google.com with SMTP id v9-20020a17090a7c09b02901778a2a8fd6so2221233pjf.3 for ; Tue, 03 Aug 2021 00:58:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=4067Q/uBr5whrrksAorpAMgFNv8fx79XPkLrnKf4gpY=; b=XtCGuBDZVy0kfmRo7FsjZFPr6Ct4FxXYCCd2+BhUr6RkHUKhGoZ4hXRysjoqNboibM Nj0Ti3n30YF5vChITGg7zincNBm4DDOIm4FGLxuOdxIqM6ey4uB7kazEnVdIxQFSe8b1 dMnr2soIJCYJxGE4XxHGIm+tUm1h9z/Iz/r9ixyywx6nSytiJVuyRnmsHATpomuOA8ml 3HhU8l1Ov/aMHBwUaEd8xFG8/SJtwS4XFrYa8oAysepEKVcZevmXollmQng5YeK23S0c Z0i9AV365ta4da03F6lc54ooEUVmeX3pXXJNGL9/e0dnhRWhKI9haLepkD2KGHh7Y2cj fG+A== X-Gm-Message-State: AOAM533NLbr4FV1n6QaWgWnFP7/ACi9uf31bWWG1q6cgtT2RCqyo90Oa 4M+fJJmPBsAU+jROGDZ00lmpVB6VYKo3PghNElb8hjTPzvcEF2/DgsbzvnDV8V3Mhqo385CYIis c0X9PMvZwJW2KF522/xJMcf1TwimZX0cPVKPT3qwzSuhrLLT4dIJ8y5pFJfiNX6ktERcyx31d6a zo X-Received: by 2002:a62:64ce:0:b029:3b8:90c:6eec with SMTP id y197-20020a6264ce0000b02903b8090c6eecmr13054254pfb.9.1627977520865; Tue, 03 Aug 2021 00:58:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjX5wUayvV2kr5HqNyIW/IueFG/FKVhos2G8U/pZi0sFBb3YPj3+qYU1BLVJyBkEZqQdqW6A== X-Received: by 2002:a62:64ce:0:b029:3b8:90c:6eec with SMTP id y197-20020a6264ce0000b02903b8090c6eecmr13054211pfb.9.1627977520538; Tue, 03 Aug 2021 00:58:40 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id s133sm4953282pfs.190.2021.08.03.00.58.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 00:58:40 -0700 (PDT) Subject: Re: [PATCH v10 04/17] vdpa: Fail the vdpa_reset() if fail to set device status to zero To: Xie Yongji , mst@redhat.com, stefanha@redhat.com, sgarzare@redhat.com, parav@nvidia.com, hch@infradead.org, christian.brauner@canonical.com, rdunlap@infradead.org, willy@infradead.org, viro@zeniv.linux.org.uk, axboe@kernel.dk, bcrl@kvack.org, corbet@lwn.net, mika.penttila@nextfour.com, dan.carpenter@oracle.com, joro@8bytes.org, gregkh@linuxfoundation.org, zhe.he@windriver.com, xiaodong.liu@intel.com, joe@perches.com Cc: songmuchun@bytedance.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20210729073503.187-1-xieyongji@bytedance.com> <20210729073503.187-5-xieyongji@bytedance.com> From: Jason Wang Message-ID: <39a191f6-555b-d2e6-e712-735b540526d0@redhat.com> Date: Tue, 3 Aug 2021 15:58:30 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210729073503.187-5-xieyongji@bytedance.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/7/29 ÏÂÎç3:34, Xie Yongji дµÀ: > Re-read the device status to ensure it's set to zero during > resetting. Otherwise, fail the vdpa_reset() after timeout. > > Signed-off-by: Xie Yongji > --- > include/linux/vdpa.h | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h > index 406d53a606ac..d1a80ef05089 100644 > --- a/include/linux/vdpa.h > +++ b/include/linux/vdpa.h > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > > /** > * struct vdpa_calllback - vDPA callback definition. > @@ -340,12 +341,24 @@ static inline struct device *vdpa_get_dma_dev(struct vdpa_device *vdev) > return vdev->dma_dev; > } > > -static inline void vdpa_reset(struct vdpa_device *vdev) > +#define VDPA_RESET_TIMEOUT_MS 1000 > + > +static inline int vdpa_reset(struct vdpa_device *vdev) > { > const struct vdpa_config_ops *ops = vdev->config; > + int timeout = 0; > > vdev->features_valid = false; > ops->set_status(vdev, 0); > + while (ops->get_status(vdev)) { > + timeout += 20; > + if (timeout > VDPA_RESET_TIMEOUT_MS) > + return -EIO; > + > + msleep(20); > + } I wonder if it's better to do this in the vDPA parent? Thanks > + > + return 0; > } > > static inline int vdpa_set_features(struct vdpa_device *vdev, u64 features)