From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A361C433E4 for ; Wed, 15 Jul 2020 17:06:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 467D42065F for ; Wed, 15 Jul 2020 17:06:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Euc8fAju" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726852AbgGORGO (ORCPT ); Wed, 15 Jul 2020 13:06:14 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:45182 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbgGORGN (ORCPT ); Wed, 15 Jul 2020 13:06:13 -0400 X-Greylist: delayed 344 seconds by postgrey-1.27 at vger.kernel.org; Wed, 15 Jul 2020 13:06:12 EDT Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06FH1sGE049738; Wed, 15 Jul 2020 17:05:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=0aJpCoqDnjr2H3yULLTcmDR8DVs07rOJhh+YOn6Xk6E=; b=Euc8fAjuR8b8RtB1N8tBep927qxC8mjQG6NO1H40PJNK+MaCiyMbaZW8v1YRS8joBfc3 bK8FncQ92v/LfbaTLJ8K2LrI5nhRr7XpObGtixMz+3nNbAZTsdm0KQFmUAlqqyWDe8h2 ZwTdXjze9bz6SqPxY4TkqAOPd+7CV4ZZPnxgA8iOEb4+BCaX47W7MXSye40gxnOq8xt9 w4G5FKJqlnH7X+w4ITDwQJQulyb3kg3QN+2DhISACVOXuZMP/8VWLbezsr/PrTFwFxEN 6k2/Jlq9ZnJcRzw65tlqKY7qsCy8mXLrjk8vhzUMimL/rWXlpv0fdtx9KDcrrY7e2PzT zw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 327s65jwfp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 15 Jul 2020 17:05:39 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06FH2gpK021338; Wed, 15 Jul 2020 17:05:39 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 327qc1bkdb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Jul 2020 17:05:38 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 06FH5Y7F012218; Wed, 15 Jul 2020 17:05:34 GMT Received: from [192.168.2.112] (/50.38.35.18) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 15 Jul 2020 10:05:34 -0700 Subject: Re: [PATCH v3] mm/hugetlb: split hugetlb_cma in nodes with memory To: "Song Bao Hua (Barry Song)" , "akpm@linux-foundation.org" Cc: "x86@kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Linuxarm , "linux-arm-kernel@lists.infradead.org" , Roman Gushchin , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H.Peter Anvin" , Mike Rapoport , Anshuman Khandual , Jonathan Cameron References: <20200710120950.37716-1-song.bao.hua@hisilicon.com> <359ea1d0-b1fd-d09f-d28a-a44655834277@oracle.com> From: Mike Kravetz Message-ID: <39b23985-5611-5fba-4ec6-03f70593dea5@oracle.com> Date: Wed, 15 Jul 2020 10:05:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9683 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007150133 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9683 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 phishscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 clxscore=1015 bulkscore=0 mlxlogscore=999 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007150133 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/15/20 4:14 AM, Song Bao Hua (Barry Song) wrote: >> From: Mike Kravetz [mailto:mike.kravetz@oracle.com] >> huge_page_size(h)/1024); >> >> + if (order >= MAX_ORDER && hugetlb_cma_size) >> + hugetlb_cma_reserve(order); > > Hello, Mike, > I am not sure if it is necessarily correct as the order for gigantic pages is arch-dependent: > https://lkml.org/lkml/2020/7/1/14 > See my reply to Wil. The code to allocate gigantic pages from CMA depends on the arch independent definition of gigantic page which is 'order >= MAX_ORDER'. -- Mike Kravetz