From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E5DC433EF for ; Fri, 22 Apr 2022 23:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234237AbiDVXIg (ORCPT ); Fri, 22 Apr 2022 19:08:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234942AbiDVXIQ (ORCPT ); Fri, 22 Apr 2022 19:08:16 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 174AD23D47A for ; Fri, 22 Apr 2022 15:41:02 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id br15so2266703lfb.9 for ; Fri, 22 Apr 2022 15:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=9OGcVwu87n3nund5h+/ahM8cEAIF7XFZ15UqXk1Yef4=; b=CAbZr1b6SoLRrn/4p8RcK6MLkzVkZgvKehcD3ykk64L1/GQ5UmB431dmyJGGomJr5t dRPHBDtHDtmmCotIXNa3FMpfZrYi+pzKGLfCTdphzfy5ur+Hj4gdLnD9XHOrU2Ql1nPp JeLDHlxeu2zfMIxQj6Ir6A6i003s57R/ADVSBgIne7y4GpHjpuvtOzWcUUiOg2qIgrWK TZedyUdVBjOeQW9AspdDmo51QngzQnuez6hlfVK0RFZHmoeA5cuKYT57ag9lMEoDGKbW PYn1Psu3wJkuFyzBpeYMhGYKOUograhAi5d1twBLHe6Iv6Vvr3S1H9fK5uf5aXRdESbk DmNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=9OGcVwu87n3nund5h+/ahM8cEAIF7XFZ15UqXk1Yef4=; b=rZMJyaujrKpA3Rha1iCXw9NW768ro7d6o33DQtBTJ3tGLNXPfl5gTpyEO3vPUjy/RO VHFJSfSrR1fUJOe/ED1vIlPrfGzhPRBHZ2bJe4ANo9uwhJiCo8ikYRGSOsMx4ybnb6Xt NkBtNzusKL3G0R32rvlGlQrjgdEoLRbjyN27oR1pPpdIWS58R4uRsqYchxQK8OM/mGd7 FJfKi/Yhv3/DP6LhIzFvk6r7w+shbD5HdtPPxS2W/0tFwxVe/+mpGTVoC5gK2f6b4WJ/ 1XZ++dM6nM8WbxLHOibK999U44iBLl/RZxAgw7F8tWNbYpmTwku83OcH78ffRAwMsoGV yd+Q== X-Gm-Message-State: AOAM533PH+3J5OTQRVoexWXxnX1wPLSp8NVR4/JDQp4CGaCC0BQ7K8oq zwnRSX0nnts5Gu0AIkNjT4voNQ== X-Google-Smtp-Source: ABdhPJzys8moEhv4YW8LsUgDZNfCdy9bUPFmjV3EvTn8K635yo6mVPcZHalEKkB0DlcYfz1pZkkM7g== X-Received: by 2002:a05:6512:1193:b0:471:af88:2d74 with SMTP id g19-20020a056512119300b00471af882d74mr4515551lfr.531.1650667260391; Fri, 22 Apr 2022 15:41:00 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id e1-20020a196741000000b0046bc4be1d60sm376636lfj.123.2022.04.22.15.40.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 15:41:00 -0700 (PDT) Message-ID: <39b3828e-064c-6aa4-de77-35b201b1b40f@linaro.org> Date: Sat, 23 Apr 2022 01:40:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map() Content-Language: en-GB From: Dmitry Baryshkov To: cgel.zte@gmail.com Cc: robdclark@gmail.com, sean@poorly.run, quic_abhinavk@quicinc.com, airlied@linux.ie, daniel@ffwll.ch, swboyd@chromium.org, quic_mkrishn@quicinc.com, angelogioacchino.delregno@collabora.com, vulab@iscas.ac.cn, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Lv Ruyi , Zeal Robot References: <20220422085211.2776419-1-lv.ruyi@zte.com.cn> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/04/2022 13:42, Dmitry Baryshkov wrote: > On Fri, 22 Apr 2022 at 11:52, wrote: >> >> From: Lv Ruyi >> >> The irq_of_parse_and_map() function returns 0 on failure, and does not >> return an negative value. >> >> Reported-by: Zeal Robot >> Signed-off-by: Lv Ruyi > > Reviewed-by: Dmitry Baryshkov > >> --- >> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c >> index 3b92372e7bdf..1fb1ed9e95d9 100644 >> --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c >> +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c >> @@ -570,7 +570,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) >> } >> >> irq = irq_of_parse_and_map(pdev->dev.of_node, 0); >> - if (irq < 0) { >> + if (!irq) { >> ret = irq; As noted by Stephen, this will cause the function to prematurely return 0 (success). >> DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret); >> goto fail; >> -- >> 2.25.1 >> > > -- With best wishes Dmitry