From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C766C63777 for ; Tue, 24 Nov 2020 05:30:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C08F520719 for ; Tue, 24 Nov 2020 05:30:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbgKXF3y (ORCPT ); Tue, 24 Nov 2020 00:29:54 -0500 Received: from mxout70.expurgate.net ([91.198.224.70]:2586 "EHLO mxout70.expurgate.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725616AbgKXF3x (ORCPT ); Tue, 24 Nov 2020 00:29:53 -0500 Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1khQtf-000MZZ-Fa; Tue, 24 Nov 2020 06:29:47 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khQte-0001dF-LO; Tue, 24 Nov 2020 06:29:46 +0100 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 0E08E240041; Tue, 24 Nov 2020 06:29:46 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 7CF87240040; Tue, 24 Nov 2020 06:29:45 +0100 (CET) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id EF582204C2; Tue, 24 Nov 2020 06:29:44 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 24 Nov 2020 06:29:44 +0100 From: Martin Schiller To: Xie He Cc: Jakub Kicinski , Andrew Hendry , "David S. Miller" , Linux X25 , Linux Kernel Network Developers , LKML Subject: Re: [PATCH net-next v4 2/5] net/lapb: support netdev events Organization: TDT AG In-Reply-To: References: <20201120054036.15199-1-ms@dev.tdt.de> <20201120054036.15199-3-ms@dev.tdt.de> <87a620b6a55ea8386bffefca0a1f8b77@dev.tdt.de> <16b7e74e6e221f43420da7836659d7df@dev.tdt.de> <20201123113622.115c474b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Message-ID: <39b6386b4ce7462f6cb4448020735ed5@dev.tdt.de> X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.15 X-purgate-type: clean X-purgate: clean X-purgate-ID: 151534::1606195787-00001F6B-CD377998/0/0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-23 23:09, Xie He wrote: > On Mon, Nov 23, 2020 at 11:36 AM Jakub Kicinski > wrote: >> >> > > From this point of view it will be the best to handle the NETDEV_UP in >> > > the lapb event handler and establish the link analog to the >> > > NETDEV_CHANGE event if the carrier is UP. >> > >> > Thanks! This way we can make sure LAPB would automatically connect in >> > all situations. >> > >> > Since we'll have a netif_carrier_ok check in NETDEV_UP handing, it >> > might make the code look prettier to also have a netif_carrier_ok >> > check in NETDEV_GOING_DOWN handing (for symmetry). Just a suggestion. >> > You can do whatever looks good to you :) >> >> Xie other than this the patches look good to you? >> >> Martin should I expect a respin to follow Xie's suggestion >> or should I apply v4? > > There should be a respin because we need to handle the NETDEV_UP > event. The lapbether driver (and possibly some HDLC WAN drivers) > doesn't generate carrier events so we need to do auto-connect in the > NETDEV_UP event. I'll send a v5 with the appropriate change.