From: Laura Abbott <labbott@redhat.com>
To: Brian Starkey <brian.starkey@arm.com>
Cc: "Sumit Semwal" <sumit.semwal@linaro.org>,
"John Stultz" <john.stultz@linaro.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Riley Andrews" <riandrews@android.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
linaro-mm-sig@lists.linaro.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
"Eun Taik Lee" <eun.taik.lee@samsung.com>,
"Liviu Dudau" <Liviu.Dudau@arm.com>,
"Jon Medhurst" <tixy@linaro.org>,
"Mitchel Humpherys" <mitchelh@codeaurora.org>,
"Jeremy Gebben" <jgebben@codeaurora.org>,
"Bryan Huntsman" <bryanh@codeaurora.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Android Kernel Team" <kernel-team@android.com>,
"Chen Feng" <puck.chen@hisilicon.com>
Subject: Re: [PATCHv2 1/4] staging: android: ion: Drop heap type masks
Date: Tue, 6 Sep 2016 15:16:52 -0700 [thread overview]
Message-ID: <39b86efc-2b29-f482-cb83-7da076eb8cf6@redhat.com> (raw)
In-Reply-To: <20160905112026.GA3173@e106950-lin.cambridge.arm.com>
On 09/05/2016 04:20 AM, Brian Starkey wrote:
> Hi,
>
> On Fri, Sep 02, 2016 at 12:36:25PM -0700, Laura Abbott wrote:
>> On 09/02/2016 06:41 AM, Brian Starkey wrote:
>>> Hi Laura,
>>>
>>> On Thu, Sep 01, 2016 at 03:40:41PM -0700, Laura Abbott wrote:
>>>>
>>>> There is no advantage to having heap types be a mask. The ion client has
>>>> long since dropped the mask. Drop the notion of heap type masks as well.
>>>>
>>>
>>> I know this is the same patch you sent last time, so sorry for not
>>> picking this up then - but I'm curious what "The" ion client is here?
>>>
>>
>> ion_client_create used to take a mask to indicate what heap types it
>> could allocate from. This hasn't been the case since 2bb9f5034ec7
>> ("gpu: ion: Remove heapmask from client"). "The ion client" probably
>> should have been "struct ion_client"
>
> Ah I see, the in-kernel ion_client. Sorry, I completely forgot that
> even existed (because it's totally useless - how is a driver meant to
> find the global ion_device?)
>
>>
>>> Our ion client(s) certainly still use these masks, and it's still
>>> used as a mask within ion itself - even if the relationship between a
>>> mask and a heap type has been somewhat lost.
>>
>> Where is it used in Ion? I don't see it in tree unless I missed something
>> and I'm not eager to keep this around for out of tree code. What's the
>> actual use for this?
>
> You're certainly right that these heap-ID-to-allocation-mask macros
> are unused in the kernel, but I don't really see the reason for
> removing them - they are convenient (for now).
>
> Example: I'm using the dummy ion driver, and I want to allocate from
> the SYSTEM_CONTIG heap - the ION_HEAP_SYSTEM_CONTIG_MASK gives me the
> exact mask I need for that.
>
> It seems your opinion is that heap-IDs are already, and should be,
> completely decoupled from their type. That sounds like a good idea to
> me, but it's not true (yet) - again check out the dummy driver.
>
Good point, I need to clean up the dummy driver to stop using heap
types as the id ;)
I get that it's convenient but it's a bad practice to conflate the
namespaces.
> At the moment, heap-IDs are assigned by ion drivers in any way they
> see fit. For as long as that stays the case there's always going to
> be heap-masks hard-coded in UAPI kernel headers (in-tree or not), so
> removing these particular masks seems a bit fruitless.
>
It's not fruitless, the concept of type as mask makes no sense. They
are two different name spaces and I've found Ion users have a hard
time keeping them separate and pass in the heap type mask when using
non dummy
> I'd rather see driver-assigned heap-IDs disappear completely, and have
> them assigned by ion core from an idr or something. At that point
> these macros really *are* meaningless, and I'd be totally fine with
> removing them (and userspace won't be able to depend on hard-coded
> allocation masks any more - it will have to use the query ioctl,
> which I assume is the whole point?).
>
Ideally yes we'd be able to get rid of the hard coded device IDs.
I consider the query ioctl a stepping stone to that, depending on
how enthusiastic people are about Ion.
> IMO it's not the right time to remove these macros, because they still
> have meaning and usefulness.
>
I still think they should be deleted to avoid namespace polution.
> Cheers,
> Brian
>
>>
>>>
>>> Thanks,
>>> Brian
>>>
>>>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>>>> ---
>>>> drivers/staging/android/uapi/ion.h | 6 ------
>>>> 1 file changed, 6 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
>>>> index 0a8e40f..a9c4e8b 100644
>>>> --- a/drivers/staging/android/uapi/ion.h
>>>> +++ b/drivers/staging/android/uapi/ion.h
>>>> @@ -44,14 +44,8 @@ enum ion_heap_type {
>>>> * must be last so device specific heaps always
>>>> * are at the end of this enum
>>>> */
>>>> - ION_NUM_HEAPS = 16,
>>>> };
>>>>
>>>> -#define ION_HEAP_SYSTEM_MASK (1 << ION_HEAP_TYPE_SYSTEM)
>>>> -#define ION_HEAP_SYSTEM_CONTIG_MASK (1 << ION_HEAP_TYPE_SYSTEM_CONTIG)
>>>> -#define ION_HEAP_CARVEOUT_MASK (1 << ION_HEAP_TYPE_CARVEOUT)
>>>> -#define ION_HEAP_TYPE_DMA_MASK (1 << ION_HEAP_TYPE_DMA)
>>>> -
>>>> #define ION_NUM_HEAP_IDS (sizeof(unsigned int) * 8)
>>>>
>>>> /**
>>>> --
>>>> 2.7.4
>>>>
>>
next prev parent reply other threads:[~2016-09-06 22:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 22:40 [PATCHv2 0/4] New Ion ioctls Laura Abbott
2016-09-01 22:40 ` [PATCHv2 1/4] staging: android: ion: Drop heap type masks Laura Abbott
2016-09-02 13:41 ` Brian Starkey
2016-09-02 19:36 ` Laura Abbott
2016-09-05 11:20 ` Brian Starkey
2016-09-06 22:16 ` Laura Abbott [this message]
2016-09-07 8:50 ` Brian Starkey
2016-09-01 22:40 ` [PATCHv2 2/4] staging: android: ion: Pull out ion ioctls to a separate file Laura Abbott
2016-09-02 12:44 ` Greg Kroah-Hartman
2016-09-02 19:53 ` Laura Abbott
2016-09-01 22:40 ` [PATCHv2 3/4] staging: android: ion: Add an ioctl for ABI checking Laura Abbott
2016-09-02 6:10 ` Greg Kroah-Hartman
2016-09-02 20:26 ` Laura Abbott
2016-09-02 9:02 ` [Linaro-mm-sig] " Arnd Bergmann
2016-09-02 20:33 ` Laura Abbott
2016-09-02 21:33 ` Arnd Bergmann
2016-09-02 22:14 ` Laura Abbott
2016-09-01 22:40 ` [PATCHv2 4/4] staging: android: ion: Add ioctl to query available heaps Laura Abbott
2016-09-01 23:44 ` kbuild test robot
2016-09-02 21:27 ` Laura Abbott
2016-09-02 21:37 ` [Linaro-mm-sig] " Arnd Bergmann
2016-09-02 21:53 ` Laura Abbott
2016-09-02 6:14 ` Greg Kroah-Hartman
2016-09-02 20:41 ` Laura Abbott
2016-09-03 12:55 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39b86efc-2b29-f482-cb83-7da076eb8cf6@redhat.com \
--to=labbott@redhat.com \
--cc=Liviu.Dudau@arm.com \
--cc=arve@android.com \
--cc=brian.starkey@arm.com \
--cc=bryanh@codeaurora.org \
--cc=daniel.vetter@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=eun.taik.lee@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgebben@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitchelh@codeaurora.org \
--cc=puck.chen@hisilicon.com \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).