linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maulik Shah <quic_mkshah@quicinc.com>
To: Luca Weiss <luca.weiss@fairphone.com>, <linux-arm-msm@vger.kernel.org>
Cc: <~postmarketos/upstreaming@lists.sr.ht>,
	<phone-devel@vger.kernel.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>, "Rob Herring" <robh+dt@kernel.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: qcom,pdc: convert to YAML
Date: Mon, 20 Dec 2021 17:54:42 +0530	[thread overview]
Message-ID: <39d259cf-5663-5073-f16b-71a21f0e62e3@quicinc.com> (raw)
In-Reply-To: <20211213152208.290923-1-luca.weiss@fairphone.com>

Hi Luca,

On 12/13/2021 8:52 PM, Luca Weiss wrote:
> Convert the PDC interrupt controller bindings to YAML.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> This patch depends on the following patch, which fixed sm8250 & sm8350
> compatibles and adds sm6350.
> https://lore.kernel.org/linux-arm-msm/20211213082614.22651-4-luca.weiss@fairphone.com/
>
> Also, if somebody has a better suggestion for the register names,
> the second one is pulled from downstream commit message which calls it
> both "SPI config registers" and "interface registers":
> https://source.codeaurora.org/quic/la/kernel/msm-4.19/commit/?id=cdefb63745e051a5bcf69663ac9d084d7da1eeec

Thanks for the patch. Please use "apss-shared-spi-cfg" name for the 
second reg.

It was intended in [1] to remove it since there are no user in upstream 
for second reg. but it should be fine to convert existing to yaml first 
and then look to fix that.

[1] 
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=449725&state=%2A&archive=both

[2] 
https://patchwork.kernel.org/project/linux-arm-msm/patch/1616409015-27682-1-git-send-email-mkshah@codeaurora.org/

Thanks,
Maulik
>
>   .../interrupt-controller/qcom,pdc.txt         | 77 -----------------
>   .../interrupt-controller/qcom,pdc.yaml        | 86 +++++++++++++++++++
>   2 files changed, 86 insertions(+), 77 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
>   create mode 100644 Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
>

  parent reply	other threads:[~2021-12-20 12:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 15:22 [PATCH] dt-bindings: qcom,pdc: convert to YAML Luca Weiss
2021-12-15 20:18 ` Rob Herring
2021-12-20 12:24 ` Maulik Shah [this message]
2021-12-29  9:41   ` Luca Weiss
2022-01-02  6:27     ` Maulik Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39d259cf-5663-5073-f16b-71a21f0e62e3@quicinc.com \
    --to=quic_mkshah@quicinc.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=maz@kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).