From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935494AbcKDPNc (ORCPT <rfc822;w@1wt.eu>);
        Fri, 4 Nov 2016 11:13:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33902 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752436AbcKDPNb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 4 Nov 2016 11:13:31 -0400
Subject: Re: [PATCH v3] x86/cpuid: expose AVX512_4VNNIW and AVX512_4FMAPS
 features to kvm guest
To: Borislav Petkov <bp@alien8.de>
References: <1478243239-15586-1-git-send-email-he.chen@linux.intel.com>
 <20161104105235.qbqvmsv4ikajvjtu@pd.tnic>
 <ecdc20d5-e5c2-cab7-2973-39c811cac42c@redhat.com>
 <20161104150637.ejyxq5rfwcwggo3q@pd.tnic>
Cc: He Chen <he.chen@linux.intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, Luwei Kang <luwei.kang@intel.com>,
        Piotr Luc <Piotr.Luc@intel.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <39d57b21-671d-8c25-8d25-ba2cfd0dc4f9@redhat.com>
Date: Fri, 4 Nov 2016 16:13:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161104150637.ejyxq5rfwcwggo3q@pd.tnic>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 04 Nov 2016 15:13:30 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 04/11/2016 16:06, Borislav Petkov wrote:
> > With no usage?  Sounds like a good use of Acked-by. :)
> I don't understand what do you mean here?

I mean that the changes to scattered.c are small, so it makes no sense
to split them.  With an Acked-by I could simply take the patch into my tree.

Paolo

>>>> > >> +u32 get_scattered_cpuid_leaf(unsigned int level, unsigned int sub_leaf,
>>>> > >> +			     enum cpuid_regs_idx reg)
>>> > > 
>>> > > Align arguments on the opening brace.
>> > 
>> > They are aligned.
> Right you are. I need to look into why those spaces get eaten in vim.
> Looks like something is replacing 4 spaces with a single one...