From: David Engraf <david.engraf@sysgo.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: richard.genoud@gmail.com, jslaby@suse.com,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
ludovic.desroches@microchip.com, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty/serial: atmel: fix out of range clock divider handling
Date: Mon, 16 Dec 2019 09:34:09 +0100 [thread overview]
Message-ID: <39e4d1c7-20b0-a024-3a46-e4d4369eed8e@sysgo.com> (raw)
In-Reply-To: <20191213160726.GB2632926@kroah.com>
On 13.12.19 at 17:07, Greg KH wrote:
> On Fri, Dec 13, 2019 at 03:03:01PM +0100, David Engraf wrote:
>> Use MCK_DIV8 when the clock divider is > 65535. Unfortunately the mode
>> register was already written thus the clock selection is ignored.
>>
>> Fix by doing the baud rate calulation before setting the mode.
>>
>> Fixes: 5bf5635ac170 ("tty/serial: atmel: add fractional baud rate support")
>> Signed-off-by: David Engraf <david.engraf@sysgo.com>
>> ---
>> drivers/tty/serial/atmel_serial.c | 43 ++++++++++++++++---------------
>> 1 file changed, 22 insertions(+), 21 deletions(-)
>
> What changed from v1?
>
> Always put that below the --- line.
Oh sorry.
> v3 please?
Sure.
Best regards
- David
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2019-12-16 8:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 16:29 [PATCH] tty/serial: atmel: fix out of range clock divider handling David Engraf
2019-12-13 9:57 ` Richard Genoud
2019-12-13 13:49 ` David Engraf
2019-12-13 14:03 ` [PATCH v2] " David Engraf
2019-12-13 16:07 ` Greg KH
2019-12-16 8:34 ` David Engraf [this message]
2019-12-16 8:54 ` [PATCH v3] " David Engraf
2019-12-16 10:03 ` Richard Genoud
2019-12-16 10:26 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e4d1c7-20b0-a024-3a46-e4d4369eed8e@sysgo.com \
--to=david.engraf@sysgo.com \
--cc=alexandre.belloni@bootlin.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).