From: Joe Perches <joe@perches.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Pavel Machek" <pavel@ucw.cz>, "Len Brown" <len.brown@intel.com>,
linux-pm@vger.kernel.org, "Petr Mladek" <pmladek@suse.com>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"Andy Whitcroft" <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH v2 2/3] checkpatch: handle new pr_<level>_cont macros
Date: Fri, 25 Nov 2022 12:17:05 -0800 [thread overview]
Message-ID: <39f687f7c71b162eb8caefbec939fa2ad74fcdfc.camel@perches.com> (raw)
In-Reply-To: <20221125190948.2062-3-linux@weissschuh.net>
On Fri, 2022-11-25 at 20:09 +0100, Thomas Weißschuh wrote:
> These new macros from include/linux/printk.h replace the usage of plain
> pr_cont().
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 1e5e66ae5a52..fb1747639c9c 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -590,7 +590,7 @@ our $zero_initializer = qr{(?:(?:0[xX])?0+$Int_type?|NULL|false)\b};
>
> our $logFunctions = qr{(?x:
> printk(?:_ratelimited|_once|_deferred_once|_deferred|)|
> - (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
> + (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|_cont|)|
OK
> TP_printk|
> WARN(?:_RATELIMIT|_ONCE|)|
> panic|
> @@ -6374,11 +6374,17 @@ sub process {
> }
>
> # check for logging continuations
> - if ($line =~ /\bprintk\s*\(\s*KERN_CONT\b|\bpr_cont\s*\(/) {
> + if ($line =~ /\bprintk\s*\(\s*KERN_CONT\b|\bpr_([a-z]+_)?cont\s*\(/) {
> WARN("LOGGING_CONTINUATION",
> "Avoid logging continuation uses where feasible\n" . $herecurr);
> }
OK
> +# check for logging continuations without explicit level
> + if ($line =~ /\bpr_cont\s*\(/) {
> + WARN("LOGGING_CONTINUATION_WITHOUT_LEVEL",
> + "Avoid logging continuation without level\n" . $herecurr);
> + }
> +
Not so sure about this one.
I think relatively few situations are going to require interleaving avoidance.
> # check for unnecessary use of %h[xudi] and %hh[xudi] in logging functions
> if (defined $stat &&
> $line =~ /\b$logFunctions\s*\(/ &&
next prev parent reply other threads:[~2022-11-25 20:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 19:09 [PATCH v2 0/3] printk: introduce new macros pr_<level>_cont() Thomas Weißschuh
2022-11-25 19:09 ` [PATCH v2 1/3] " Thomas Weißschuh
2022-11-25 20:18 ` Joe Perches
2022-11-25 20:33 ` Thomas Weißschuh
2022-11-30 13:59 ` Petr Mladek
2022-11-30 14:50 ` Thomas Weißschuh
2022-12-02 12:21 ` Petr Mladek
2022-11-30 14:23 ` Petr Mladek
2022-11-30 14:56 ` Thomas Weißschuh
2022-12-02 12:27 ` Petr Mladek
2022-11-25 19:09 ` [PATCH v2 2/3] checkpatch: handle new pr_<level>_cont macros Thomas Weißschuh
2022-11-25 20:17 ` Joe Perches [this message]
2022-11-30 14:51 ` Petr Mladek
2022-11-25 19:09 ` [PATCH v2 3/3] power: process: use explicit levels for printk continuations Thomas Weißschuh
2022-11-25 19:53 ` Joe Perches
2022-11-25 20:41 ` Thomas Weißschuh
2022-11-30 15:06 ` Petr Mladek
2022-11-30 17:57 ` [PATCH v2 0/3] printk: introduce new macros pr_<level>_cont() Rafael J. Wysocki
2022-11-30 23:37 ` Thomas Weißschuh
2022-12-01 10:32 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39f687f7c71b162eb8caefbec939fa2ad74fcdfc.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=lukas.bulwahn@gmail.com \
--cc=pavel@ucw.cz \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).