From: Yonghong Song <yhs@fb.com>
To: Bixuan Cui <cuibixuan@huawei.com>, <bpf@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <ast@kernel.org>, <daniel@iogearbox.net>, <andrii@kernel.org>,
<kafai@fb.com>, <songliubraving@fb.com>,
<john.fastabend@gmail.com>, <kpsingh@kernel.org>
Subject: Re: [PATCH -next v2] bpf: Add oversize check before call kvcalloc()
Date: Sun, 12 Sep 2021 19:25:02 -0700 [thread overview]
Message-ID: <39ffe740-0092-61ee-5af7-8de41b5700c0@fb.com> (raw)
In-Reply-To: <20210911005557.45518-1-cuibixuan@huawei.com>
On 9/10/21 5:55 PM, Bixuan Cui wrote:
> Commit 7661809d493b ("mm: don't allow oversized kvmalloc() calls") add the
> oversize check. When the allocation is larger than what kmalloc() supports,
> the following warning triggered:
>
> WARNING: CPU: 0 PID: 8408 at mm/util.c:597 kvmalloc_node+0x108/0x110 mm/util.c:597
> Modules linked in:
> CPU: 0 PID: 8408 Comm: syz-executor221 Not tainted 5.14.0-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> RIP: 0010:kvmalloc_node+0x108/0x110 mm/util.c:597
> Call Trace:
> kvmalloc include/linux/mm.h:806 [inline]
> kvmalloc_array include/linux/mm.h:824 [inline]
> kvcalloc include/linux/mm.h:829 [inline]
> check_btf_line kernel/bpf/verifier.c:9925 [inline]
> check_btf_info kernel/bpf/verifier.c:10049 [inline]
> bpf_check+0xd634/0x150d0 kernel/bpf/verifier.c:13759
> bpf_prog_load kernel/bpf/syscall.c:2301 [inline]
> __sys_bpf+0x11181/0x126e0 kernel/bpf/syscall.c:4587
> __do_sys_bpf kernel/bpf/syscall.c:4691 [inline]
> __se_sys_bpf kernel/bpf/syscall.c:4689 [inline]
> __x64_sys_bpf+0x78/0x90 kernel/bpf/syscall.c:4689
> do_syscall_x64 arch/x86/entry/common.c:50 [inline]
> do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
> entry_SYSCALL_64_after_hwframe+0x44/0xae
>
> Reported-by: syzbot+f3e749d4c662818ae439@syzkaller.appspotmail.com
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
Acked-by: Yonghong Song <yhs@fb.com>
prev parent reply other threads:[~2021-09-13 2:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 0:55 [PATCH -next v2] bpf: Add oversize check before call kvcalloc() Bixuan Cui
2021-09-13 2:25 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39ffe740-0092-61ee-5af7-8de41b5700c0@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cuibixuan@huawei.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).